Tidy handling of intrinsics for f128#863
Merged
antoyo merged 5 commits intorust-lang:masterfrom Mar 15, 2026
Merged
Conversation
N1ark
force-pushed
the
tidy-float-intrinsics
branch
from
4cf4286 to
41f5085
Compare
antoyo
approved these changes
Mar 15, 2026
Contributor
|
Thanks for the nice improvement! |
This was referenced Mar 15, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a TODO, to only call
get_simple_function_f128if the intrinsic is an f128 intrinsic.Took it as an opportunity to clean up that part of the code a bit.
This PR introduces one behaviour change: intrinsics
minimumf128andmaximumf128now only get generated if f128 is supported; they used to be generated unconditionally.