Skip to content

Tidy handling of intrinsics for f128 #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoyo merged 5 commits into from
Mar 15, 2026
Merged

Tidy handling of intrinsics for f128 #863

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
25a7f23
Move `powif16` next to `powif128`
N1ark Mar 14, 2026
99aecac
handle minimumf128/maximumf128 in get_simple_function_f128_2args
N1ark Mar 14, 2026
f67c935
Simplify get_simple_function
N1ark Mar 14, 2026
2acd77e
Fix TODO: only call f128 fns if is a f128 fn
N1ark Mar 14, 2026
41f5085
Inline `get_simple_function`
N1ark Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 68 additions & 97 deletions src/intrinsic/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,80 +95,10 @@ fn get_simple_intrinsic<'gcc, 'tcx>(
Some(cx.context.get_builtin_function(gcc_name))
}

// TODO(antoyo): We can probably remove these and use the fallback intrinsic implementation.
fn get_simple_function<'gcc, 'tcx>(
cx: &CodegenCx<'gcc, 'tcx>,
name: Symbol,
) -> Option<Function<'gcc>> {
let (return_type, parameters, func_name) = match name {
sym::minimumf32 => {
let parameters = [
cx.context.new_parameter(None, cx.float_type, "a"),
cx.context.new_parameter(None, cx.float_type, "b"),
];
(cx.float_type, parameters, "fminimumf")
}
sym::minimumf64 => {
let parameters = [
cx.context.new_parameter(None, cx.double_type, "a"),
cx.context.new_parameter(None, cx.double_type, "b"),
];
(cx.double_type, parameters, "fminimum")
}
sym::minimumf128 => {
let f128_type = cx.type_f128();
// GCC doesn't have the intrinsic we want so we use the compiler-builtins one
// https://docs.rs/compiler_builtins/latest/compiler_builtins/math/full_availability/fn.fminimumf128.html
let parameters = [
cx.context.new_parameter(None, f128_type, "a"),
cx.context.new_parameter(None, f128_type, "b"),
];
(f128_type, parameters, "fminimumf128")
}
sym::maximumf32 => {
let parameters = [
cx.context.new_parameter(None, cx.float_type, "a"),
cx.context.new_parameter(None, cx.float_type, "b"),
];
(cx.float_type, parameters, "fmaximumf")
}
sym::maximumf64 => {
let parameters = [
cx.context.new_parameter(None, cx.double_type, "a"),
cx.context.new_parameter(None, cx.double_type, "b"),
];
(cx.double_type, parameters, "fmaximum")
}
sym::maximumf128 => {
let f128_type = cx.type_f128();
// GCC doesn't have the intrinsic we want so we use the compiler-builtins one
// https://docs.rs/compiler_builtins/latest/compiler_builtins/math/full_availability/fn.fmaximumf128.html
let parameters = [
cx.context.new_parameter(None, f128_type, "a"),
cx.context.new_parameter(None, f128_type, "b"),
];
(f128_type, parameters, "fmaximumf128")
}
_ => return None,
};
Some(cx.context.new_function(
None,
FunctionType::Extern,
return_type,
&parameters,
func_name,
false,
))
}

fn get_simple_function_f128<'gcc, 'tcx>(
cx: &CodegenCx<'gcc, 'tcx>,
name: Symbol,
) -> Option<Function<'gcc>> {
if !cx.supports_f128_type {
return None;
}

) -> Function<'gcc> {
let f128_type = cx.type_f128();
let func_name = match name {
sym::ceilf128 => "ceilf128",
Expand All @@ -178,34 +108,35 @@ fn get_simple_function_f128<'gcc, 'tcx>(
sym::roundf128 => "roundf128",
sym::round_ties_even_f128 => "roundevenf128",
sym::sqrtf128 => "sqrtf128",
_ => return None,
_ => unreachable!(),
};
Some(cx.context.new_function(
cx.context.new_function(
None,
FunctionType::Extern,
f128_type,
&[cx.context.new_parameter(None, f128_type, "a")],
func_name,
false,
))
)
}

fn get_simple_function_f128_2args<'gcc, 'tcx>(
cx: &CodegenCx<'gcc, 'tcx>,
name: Symbol,
) -> Option<Function<'gcc>> {
if !cx.supports_f128_type {
return None;
}

) -> Function<'gcc> {
let f128_type = cx.type_f128();
let func_name = match name {
// GCC doesn't have the intrinsic we want so we use the compiler-builtins one
// https://docs.rs/compiler_builtins/latest/compiler_builtins/math/full_availability/fn.fmaximumf128.html
// https://docs.rs/compiler_builtins/latest/compiler_builtins/math/full_availability/fn.fminimumf128.html
sym::maximumf128 => "fmaximumf128",
sym::minimumf128 => "fminimumf128",
sym::maxnumf128 => "fmaxf128",
sym::minnumf128 => "fminf128",
sym::copysignf128 => "copysignf128",
_ => return None,
_ => unreachable!(),
};
Some(cx.context.new_function(
cx.context.new_function(
None,
FunctionType::Extern,
f128_type,
Expand All @@ -215,7 +146,7 @@ fn get_simple_function_f128_2args<'gcc, 'tcx>(
],
func_name,
false,
))
)
}

fn f16_builtin<'gcc, 'tcx>(
Expand All @@ -233,13 +164,6 @@ fn f16_builtin<'gcc, 'tcx>(
sym::maxnumf16 => "__builtin_fmaxf",
sym::minnumf16 => "__builtin_fminf",
sym::powf16 => "__builtin_powf",
sym::powif16 => {
let func = cx.context.get_builtin_function("__builtin_powif");
let arg0 = cx.context.new_cast(None, args[0].immediate(), f32_type);
let args = [arg0, args[1].immediate()];
let result = cx.context.new_call(None, func, &args);
return cx.context.new_cast(None, result, cx.type_f16());
}
sym::roundf16 => "__builtin_roundf",
sym::round_ties_even_f16 => "__builtin_rintf",
sym::sqrtf16 => "__builtin_sqrtf",
Expand Down Expand Up @@ -269,11 +193,6 @@ impl<'a, 'gcc, 'tcx> IntrinsicCallBuilderMethods<'tcx> for Builder<'a, 'gcc, 'tc
let fn_args = instance.args;

let simple = get_simple_intrinsic(self, name);
// TODO(antoyo): Only call get_simple_function_f128 and get_simple_function_f128_2args when
// it is the symbols for the supported f128 builtins.
let simple_func = get_simple_function(self, name)
.or_else(|| get_simple_function_f128(self, name))
.or_else(|| get_simple_function_f128_2args(self, name));

let value = match name {
_ if simple.is_some() => {
Expand All @@ -284,8 +203,26 @@ impl<'a, 'gcc, 'tcx> IntrinsicCallBuilderMethods<'tcx> for Builder<'a, 'gcc, 'tc
&args.iter().map(|arg| arg.immediate()).collect::<Vec<_>>(),
)
}
_ if simple_func.is_some() => {
let func = simple_func.expect("simple function");
// TODO(antoyo): We can probably remove these and use the fallback intrinsic implementation.
sym::minimumf32 | sym::minimumf64 | sym::maximumf32 | sym::maximumf64 => {
let (ty, func_name) = match name {
sym::minimumf32 => (self.cx.float_type, "fminimumf"),
sym::maximumf32 => (self.cx.float_type, "fmaximumf"),
sym::minimumf64 => (self.cx.double_type, "fminimum"),
sym::maximumf64 => (self.cx.double_type, "fmaximum"),
_ => unreachable!(),
};
let func = self.cx.context.new_function(
None,
FunctionType::Extern,
ty,
&[
self.cx.context.new_parameter(None, ty, "a"),
self.cx.context.new_parameter(None, ty, "b"),
],
func_name,
false,
);
self.cx.context.new_call(
self.location,
func,
Expand All @@ -300,11 +237,38 @@ impl<'a, 'gcc, 'tcx> IntrinsicCallBuilderMethods<'tcx> for Builder<'a, 'gcc, 'tc
| sym::maxnumf16
| sym::minnumf16
| sym::powf16
| sym::powif16
| sym::roundf16
| sym::round_ties_even_f16
| sym::sqrtf16
| sym::truncf16 => f16_builtin(self, name, args),
sym::ceilf128
| sym::fabsf128
| sym::floorf128
| sym::truncf128
| sym::roundf128
| sym::round_ties_even_f128
| sym::sqrtf128
if self.cx.supports_f128_type =>
{
self.cx.context.new_call(
self.location,
get_simple_function_f128(self, name),
&args.iter().map(|arg| arg.immediate()).collect::<Vec<_>>(),
)
}
sym::maximumf128
| sym::minimumf128
| sym::maxnumf128
| sym::minnumf128
| sym::copysignf128
if self.cx.supports_f128_type =>
{
self.cx.context.new_call(
self.location,
get_simple_function_f128_2args(self, name),
&args.iter().map(|arg| arg.immediate()).collect::<Vec<_>>(),
)
}
sym::fmaf128 => {
let f128_type = self.cx.type_f128();
let func = self.cx.context.new_function(
Expand All @@ -325,6 +289,13 @@ impl<'a, 'gcc, 'tcx> IntrinsicCallBuilderMethods<'tcx> for Builder<'a, 'gcc, 'tc
&args.iter().map(|arg| arg.immediate()).collect::<Vec<_>>(),
)
}
sym::powif16 => {
let func = self.cx.context.get_builtin_function("__builtin_powif");
let arg0 = self.cx.context.new_cast(None, args[0].immediate(), self.cx.type_f32());
let args = [arg0, args[1].immediate()];
let result = self.cx.context.new_call(None, func, &args);
self.cx.context.new_cast(None, result, self.cx.type_f16())
}
sym::powif128 => {
let f128_type = self.cx.type_f128();
let func = self.cx.context.new_function(
Expand Down
Loading