Skip to content

Add TODO checker to cg_gcc#861

Draft
reddevilmidzy wants to merge 3 commits intorust-lang:masterfrom
reddevilmidzy:mcp-963
Draft

Add TODO checker to cg_gcc#861
reddevilmidzy wants to merge 3 commits intorust-lang:masterfrom
reddevilmidzy:mcp-963

Conversation

@reddevilmidzy
Copy link
Member

cc: rust-lang/rust#153166
MCP: rust-lang/compiler-team#963

After the commit rust-lang/rust@69f9c6a is merged here, CI will pass.

@reddevilmidzy reddevilmidzy changed the title Add TODO checker Add TODO checker to cg_gcc Mar 7, 2026
@reddevilmidzy
Copy link
Member Author

"ignoreRegExpList": [
"/(FIXME|NOTE|TODO)\\([^)]+\\)/",
"__builtin_\\w*"

Since TODOs are banned, can I remove TODO here too?

@antoyo
Copy link
Contributor

antoyo commented Mar 8, 2026

Yes

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2026

☔ The latest upstream changes (possibly #863) made this pull request unmergeable. Please resolve the merge conflicts.

rust-bors bot pushed a commit to rust-lang/rust that referenced this pull request Mar 15, 2026
Tidy: disallow TODO in other in-tree projects

Fixes: #152280
MCP: rust-lang/compiler-team#963

TODO

* [x] Add ci check to `cg_clif`: rust-lang/rustc_codegen_cranelift#1632
* [x] Add ci check to `cg_gcc`: rust-lang/rustc_codegen_gcc#861

r? lcnr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants