Command to generate pipeline container config files#3955
Open
mirpedrol wants to merge 25 commits intonf-core:devfrom
Open
Command to generate pipeline container config files#3955mirpedrol wants to merge 25 commits intonf-core:devfrom
mirpedrol wants to merge 25 commits intonf-core:devfrom
Conversation
6341cd3 to
b8004aa
Compare
mashehu
reviewed
Dec 3, 2025
mashehu
reviewed
Dec 3, 2025
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
mashehu
reviewed
Dec 4, 2025
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mashehu
approved these changes
Dec 16, 2025
mashehu
approved these changes
Jan 13, 2026
| return None | ||
|
|
||
|
|
||
| def try_generate_container_configs(directory: Path, path: Path): |
Contributor
There was a problem hiding this comment.
Suggested change
| def try_generate_container_configs(directory: Path, path: Path): | |
| def generate_container_configs(directory: Path, path: Path): |
| """Generates the container configuration files for a pipeline. | ||
|
|
||
| Args: | ||
| workflow_directory (str | Path): The directory containing the workflow files. |
Contributor
There was a problem hiding this comment.
Suggested change
| workflow_directory (str | Path): The directory containing the workflow files. | |
| workflow_directory (Path): The directory containing the workflow files. |
| ) | ||
| {% if multiqc %}ch_multiqc_files = ch_multiqc_files.mix(FASTQC.out.zip.collect{it[1]}){% endif %} | ||
| ch_versions = ch_versions.mix(FASTQC.out.versions.first()) | ||
| {% if multiqc %}ch_multiqc_files = ch_multiqc_files.mix(FASTQC.out.zip.collect{it -> it[1]}){% endif %} |
Contributor
There was a problem hiding this comment.
Suggested change
| {% if multiqc %}ch_multiqc_files = ch_multiqc_files.mix(FASTQC.out.zip.collect{it -> it[1]}){% endif %} | |
| {% if multiqc %}ch_multiqc_files = ch_multiqc_files.mix(FASTQC.out.zip.collect{file -> file[1]}){% endif %} |
f115b17 to
bfc916b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3953
Done:
nextflow inspectand obtain docker config filenf-core modules install|update|removeTODO:
Is there a case where two modules have the same name but different container? how to solve this?We couldn't find an existing case of this