[SceneChecking] Introduce SceneCheckSpecialCharacters#6025
Open
alxbilger wants to merge 2 commits intosofa-framework:masterfrom
Open
[SceneChecking] Introduce SceneCheckSpecialCharacters#6025alxbilger wants to merge 2 commits intosofa-framework:masterfrom
alxbilger wants to merge 2 commits intosofa-framework:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if nodes and components have special characters that may lead to undefined behavior.
The main problem in this PR is with the
RequiredPlugincomponent. It is design to read the plugin name in its component name, and this plugin name can contain a dot. Detecting a dot leads to spamming warnings:For example:
The dot in the name is really a problem in the current implementation of links reading. The implementation assumes that the last dot is the indication of a Data name. For
RequiredPlugin, it's not the case. A solution is to fix the links reading (for example #5995). Another case is in Python. SOFA supports to access to a component usingnode.component_name. However, ifcomponent_namecontains a dot, it will not work. So forbidding the dot is justified. For the special cases of the componentRequiredPlugin, a solution is provided in #6026.[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if