Skip to content

[CMake] Fix TinyXML2 cmake module for windeppack#6015

Merged
bakpaul merged 2 commits intosofa-framework:masterfrom
olivier-roussel:fix-cmake-tinyxml2-windeppack
Mar 13, 2026
Merged

[CMake] Fix TinyXML2 cmake module for windeppack#6015
bakpaul merged 2 commits intosofa-framework:masterfrom
olivier-roussel:fix-cmake-tinyxml2-windeppack

Conversation

@olivier-roussel
Copy link
Contributor

Since we add Pixi support for building Windows binary releases, the new CMake module for TinyXML2 is also looking for .dll file to correctly install it inside our binary package.
However, this was breaking classical usage with WinDepPack, as dll and lib files were stored alongside and the CMake module and not inside a bin/ directory.
Locally, the build did not fail on other dependencies of the WinDepPack on my side, but I'd like some feedback of other users to check if we need to fix other CMake modules.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@olivier-roussel olivier-roussel added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Mar 13, 2026
@bakpaul bakpaul merged commit 4d53af1 into sofa-framework:master Mar 13, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants