[CMake] Fix TinyXML2 cmake module for windeppack#6015
Merged
bakpaul merged 2 commits intosofa-framework:masterfrom Mar 13, 2026
Merged
[CMake] Fix TinyXML2 cmake module for windeppack#6015bakpaul merged 2 commits intosofa-framework:masterfrom
bakpaul merged 2 commits intosofa-framework:masterfrom
Conversation
bakpaul
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we add Pixi support for building Windows binary releases, the new CMake module for TinyXML2 is also looking for .dll file to correctly install it inside our binary package.
However, this was breaking classical usage with WinDepPack, as dll and lib files were stored alongside and the CMake module and not inside a bin/ directory.
Locally, the build did not fail on other dependencies of the WinDepPack on my side, but I'd like some feedback of other users to check if we need to fix other CMake modules.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if