[LinearAlgebra] Various bugfixes and add unit tests#5989
Open
fredroy wants to merge 11 commits intosofa-framework:masterfrom
Open
[LinearAlgebra] Various bugfixes and add unit tests#5989fredroy wants to merge 11 commits intosofa-framework:masterfrom
fredroy wants to merge 11 commits intosofa-framework:masterfrom
Conversation
replacing 3*nBRow with nBRow*nBCol so that clear() iterates over the actual number of allocated blocks instead of a hardcoded factor of 3.
The ResizeBlockNonSquare test specifically covers the regression for commit 6558a85 (the nBlockRow == nbBRow && nBlockCol == nbBCol fix), verifying that resizing with same rows but different cols (or vice versa) triggers a full reset rather than just zeroing values.
…or (missing template)
fredroy
added
pr: fix
Contributor
Author
|
[ci-build][with-all-tests] |
bakpaul
approved these changes
Mar 5, 2026
| for (Index j=0; j<BSIZE; ++j) | ||
| { | ||
| r += bloc(bi,bj)[i][j] * v[(bi + bj - 1)*BSIZE + j]; | ||
| r += bloc(bi,bj)[i][j] * v[bj*BSIZE + j]; |
Contributor
There was a problem hiding this comment.
This was so wrong I don't understand how it worked previously. Is it used anywhere ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlockFullMatrix:
SparseMatrix:
CompressedRowSparseMatrixGeneric:
CompressedRowSparseMatrixMechanical:
CompressedRowSparseMatrixConstraint:
+ add unit tests for all those 5 classes
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if