Skip to content

[Helper] Add getName method to all MessageHandler implementations and update related tests#5979

Open
alxbilger wants to merge 1 commit intosofa-framework:masterfrom
alxbilger:getname
Open

[Helper] Add getName method to all MessageHandler implementations and update related tests#5979
alxbilger wants to merge 1 commit intosofa-framework:masterfrom
alxbilger:getname

Conversation

@alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Feb 26, 2026

It helps for debugging

Breaking because the newly added method is pure virtual.

[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/590]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Feb 26, 2026
@alxbilger alxbilger added the pr: breaking Change possibly inducing a compilation error label Mar 10, 2026
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@sofabot
Copy link
Collaborator

sofabot commented Mar 12, 2026

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@hugtalbot
Copy link
Contributor

Error on Win :

J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): error C2259: 'sofapython3::MessageHandler_Trampoline': cannot instantiate abstract class
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3/Sofa/Helper/Binding_MessageHandler.h(38): note: see declaration of 'sofapython3::MessageHandler_Trampoline'
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): note: due to following members:
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): note: 'std::string sofa::helper::logging::MessageHandler::getName(void) const': is abstract
J:\0\src\Sofa\framework\Helper\src\sofa/helper/logging/MessageHandler.h(43): note: see declaration of 'sofa::helper::logging::MessageHandler::getName'
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): error C2259: 'sofapython3::MessageHandler_Trampoline': cannot instantiate abstract class
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3/Sofa/Helper/Binding_MessageHandler.h(38): note: see declaration of 'sofapython3::MessageHandler_Trampoline'
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): note: due to following members:
J:\0\build\external_directories\fetched\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\Binding_MessageHandler.cpp(94): note: 'std::string sofa::helper::logging::MessageHandler::getName(void) const': is abstract
J:\0\src\Sofa\framework\Helper\src\sofa/helper/logging/MessageHandler.h(43): note: see declaration of 'sofa::helper::logging::MessageHandler::getName'
[1488/2411] Building CXX object applications\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Helper\CMakeFiles\Bindings.Sofa.Helper.dir\System\Binding_FileRepository.cpp.obj
[1489/2411] Building CXX object applications\SofaPython3\bindings\Sofa\src\SofaPython3\Sofa\Simulation\CMakeFiles\Bindings.Sofa.Simulation.dir\Binding_SceneCheck.cpp.obj
[1490/2411] Linking CXX shared library lib\python3\site-packages\Sofa\Core.cp310-win_amd64.pyd
ninja: build stopped: subcommand failed.
ERROR: Detected /J/0/build/make-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants