[Mapping] Introduce SubsetTopologicalMultiMapping with multiple topology inputs and one output#5952
Open
th-skam wants to merge 6 commits intosofa-framework:masterfrom
Open
[Mapping] Introduce SubsetTopologicalMultiMapping with multiple topology inputs and one output#5952th-skam wants to merge 6 commits intosofa-framework:masterfrom
th-skam wants to merge 6 commits intosofa-framework:masterfrom
Conversation
…ological mappings [scenes] Update scene accordingly
th-skam
added
pr: status to review
Contributor
|
[ci-build][with-all-tests] |
alxbilger
reviewed
Mar 3, 2026
Contributor
alxbilger
left a comment
alxbilger
left a comment
There was a problem hiding this comment.
If I am not mistaken, the code corresponds more to IdentityTopologicalMultiMapping than SubsetTopologicalMultiMapping. For me, Subset means that you filter part of the input topologies. What do you think?
| d_indexPairs(initData(&d_indexPairs, sofa::type::vector<unsigned>(), "indexPairs", | ||
| "Output: flat array of (source_index, coord_in_source) pairs")) | ||
| { | ||
| d_indexPairs.setReadOnly(true); |
Contributor
There was a problem hiding this comment.
you can eventually add d_indexPairs to the group "Outputs"
th-skam
added
pr: status wip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new
SubsetTopologicalMultiMappingcomponent that works with theSubsetMultiMapping, similar to the existingSubsetTopologicalMapping-SubsetMappingrelationship.There can be multiple inputs which are mapped/merged into a unified topology. This is done by offsetting the index addressing list of the mapped topological elements.
In addition, it generates an
indexPairsarray that can be linked to aSubsetMultiMappingcomponent so that mechanical information can be propagated from and to subset nodes.For triangles/quads, I added the option to flip normal vector orientation.
I also added a scene to demonstrate this.
[with-all-tests]