Move FwLite and Lexbox to .NET 10#2262
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR upgrades the entire project from .NET SDK 9.x to 10.x. Changes are applied uniformly across global build properties, project target frameworks, CI/CD workflows, Docker base images, VS Code debug configurations, build automation tasks, and documentation to maintain consistency across all development and deployment pathways. Changes.NET 10 Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
C# Unit Tests165 tests 165 ✅ 19s ⏱️ Results for commit b529aa3. ♻️ This comment has been updated with latest results. |
UI unit Tests 1 files 59 suites 31s ⏱️ Results for commit b529aa3. ♻️ This comment has been updated with latest results. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
@coderabbitai Can you recommend how to deal with the five "The call is ambiguous between the following methods or properties" errors on the five uses of .ToArrayAsync() in MiniLcmApiExtensions.cs? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chainLet me look at the file in question to give a precise recommendation. 🏁 Script executed: Length of output: 729 Now let me check the project file and package references to pinpoint the conflict. 🏁 Script executed: Length of output: 917 Now I have a clear picture of the root cause. Let me confirm the .NET 10 migration guidance.
Your Recommended fix: If you're upgrading to .NET 10 and your code includes a direct package reference to Since - <PackageReference Include="System.Linq.Async" />The five
|
System.Linq.Async is no longer needed when building with .NET 10, as the AsyncEnumerable functionality it provides has been included in the baseline .NET 10 library now. Version 7 of the NuGet package is a transitional package, intended for projects to use while they make any code changes their code might need (e.g. SelectAsync -> Select and so on)
|
See https://endjin.com/blog/ix-v7-dotnet-10-linq-iasyncenumerable (linked from https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/10.0/asyncenumerable) for more details on the transition. |
Reinforced.Typings 1.6.5 only supported .NET versions up to 9.
Apparently we might need to do an explicit `dotnet workload install maui` step in order to get the MAUI workload. Failing that, there's also a Windows2025-VS2026 image we could try.
|
First run of |
|
It was just the build runner getting stuck. Maybe yet another Azure hiccup behind the scenes. Rerunning the tests succeeded in 13 minutes. |
|
@rmunn I've seen that about 5 times. |
myieye
left a comment
There was a problem hiding this comment.
🥳
Looks good to me.
It'd definitely be good to bump and cleanup nugets after this.
Fixes #2227.
Fixes #2228.
Currently fails to compile with a single "extension method is ambiguous" error on AsyncEnumerable.ToArrayAsync. Opening a PR anyway so that I can get an AI code review, which might help inform me of the C# syntax I need to disambiguate these (since I don't know that particular syntax off the top of my head).