Skip to content

Add commits index and sync benchmarks#2254

Open
myieye wants to merge 6 commits into
developfrom
sync-perf-benchmarks
Open

Add commits index and sync benchmarks#2254
myieye wants to merge 6 commits into
developfrom
sync-perf-benchmarks

Conversation

@myieye
Copy link
Copy Markdown
Collaborator

@myieye myieye commented May 5, 2026

Adds various sync benchmark tests.
The motivation for this is that I was exploring performance optimizations and having a benchmark in place lets me/us actually measure those optimizations.
This PR includes the first and smallest optimization: a DB index on the commit order columns.
So, now there are 2 Comment lines per benchmark documenting the approximate speedup that the index resulted in.

Hopefully future PRs will add more radical speedups.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

Warning

Rate limit exceeded

@myieye has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 1 second before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4ae3ff7e-44ad-41bf-a2e9-d6d223bd3ee3

📥 Commits

Reviewing files that changed from the base of the PR and between 1232eea and f29fa44.

📒 Files selected for processing (11)
  • .github/workflows/fw-lite.yaml
  • backend/Directory.Packages.props
  • backend/FwLite/FwLiteProjectSync.Tests/BenchmarkSupport.cs
  • backend/FwLite/FwLiteProjectSync.Tests/Fixtures/Sena3Collection.cs
  • backend/FwLite/FwLiteProjectSync.Tests/FwLiteProjectSync.Tests.csproj
  • backend/FwLite/FwLiteProjectSync.Tests/Sena3SyncTests.cs
  • backend/FwLite/FwLiteProjectSync.Tests/SyncBenchmark.cs
  • backend/FwLite/FwLiteProjectSync.Tests/SyncMutationBenchmark.cs
  • backend/FwLite/FwLiteProjectSync.Tests/XUnitBenchmarkLogger.cs
  • backend/FwLite/LcmCrdt/Migrations/20260506150734_AddCommitsOrderIndex.Designer.cs
  • backend/FwLite/LcmCrdt/Migrations/20260506150734_AddCommitsOrderIndex.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync-perf-benchmarks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

C# Unit Tests

165 tests   165 ✅  18s ⏱️
 23 suites    0 💤
  1 files      0 ❌

Results for commit f29fa44.

♻️ This comment has been updated with latest results.

@argos-ci
Copy link
Copy Markdown

argos-ci Bot commented May 5, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - May 7, 2026, 4:02 PM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

UI unit Tests

  1 files   59 suites   30s ⏱️
176 tests 176 ✅ 0 💤 0 ❌
245 runs  245 ✅ 0 💤 0 ❌

Results for commit f29fa44.

♻️ This comment has been updated with latest results.

@myieye myieye force-pushed the sync-perf-benchmarks branch 2 times, most recently from 0774ec3 to 2b3cb73 Compare May 6, 2026 12:58
@myieye myieye force-pushed the sync-perf-benchmarks branch from 2b3cb73 to 4f5db22 Compare May 6, 2026 15:13
@myieye myieye force-pushed the sync-perf-benchmarks branch from 403f0a7 to f29fa44 Compare May 7, 2026 15:58
@myieye myieye marked this pull request as ready for review May 8, 2026 08:35
@myieye
Copy link
Copy Markdown
Collaborator Author

myieye commented May 8, 2026

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

✅ Actions performed

Full review triggered.

@myieye myieye changed the title Add sync benchmarks Add commits index and sync benchmarks May 11, 2026
@rmunn
Copy link
Copy Markdown
Contributor

rmunn commented May 11, 2026

@myieye - I merged #2262, so you might want to rebase on top of develop. They maybe you can use the NuGet package you were talking about so you don't have to create the index manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants