-
Notifications
You must be signed in to change notification settings - Fork 175
Add Prism::Node#find_all #3878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+38
−1
Merged
Add Prism::Node#find_all #3878
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -200,7 +200,7 @@ module Prism | |
| end | ||
|
|
||
| # Returns the first node that matches the given block when visited in a | ||
| # depth-first search. This is useful for finding a node that matches a | ||
| # breadth-first search. This is useful for finding a node that matches a | ||
| # particular condition. | ||
| # | ||
| # node.breadth_first_search { |node| node.node_id == node_id } | ||
|
|
@@ -215,6 +215,26 @@ module Prism | |
|
|
||
| nil | ||
| end | ||
| alias find breadth_first_search | ||
|
|
||
| # Returns all of the nodes that match the given block when visited in a | ||
| # breadth-first search. This is useful for finding all nodes that match a | ||
|
Comment on lines
+220
to
+221
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For finding all nodes matching something, maybe a depth-first search would be faster? I'm thinking aliasing to |
||
| # particular condition. | ||
| # | ||
| # node.breadth_first_search_all { |node| node.is_a?(Prism::CallNode) } | ||
| # | ||
| def breadth_first_search_all(&block) | ||
| queue = [self] #: Array[Prism::node] | ||
| results = [] #: Array[Prism::node] | ||
|
|
||
| while (node = queue.shift) | ||
| results << node if yield node | ||
| queue.concat(node.compact_child_nodes) | ||
| end | ||
|
|
||
| results | ||
| end | ||
| alias find_all breadth_first_search_all | ||
|
|
||
| # Returns a list of the fields that exist for this node class. Fields | ||
| # describe the structure of the node. This kind of reflection is useful for | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here,
findmight be better/faster for/with DFS, especially for the example shown withnode_id.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought about that too. But I figured we can cross that bridge when we get to it if we really need to add a DFS variant.