Add Prism::Node#find_all #3878
Merged
Add Prism::Node#find_all #3878
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Jan 27, 2026
Comment on lines
+220
to
+221
| # Returns all of the nodes that match the given block when visited in a | ||
| # breadth-first search. This is useful for finding all nodes that match a |
Member
There was a problem hiding this comment.
For finding all nodes matching something, maybe a depth-first search would be faster?
I'm unsure if the order matters much in such cases, but maybe?
I'm thinking aliasing to find_all might be suboptimal if there is a DFS variant at some point.
eregon
reviewed
Jan 27, 2026
|
|
||
| nil | ||
| end | ||
| alias find breadth_first_search |
Member
There was a problem hiding this comment.
Same thing here, find might be better/faster for/with DFS, especially for the example shown with node_id.
Collaborator
Author
There was a problem hiding this comment.
Yeah, I thought about that too. But I figured we can cross that bridge when we get to it if we really need to add a DFS variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.