[Php85] Handle crash on no arg on OrdSingleByteRector#7682
Merged
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
| $args = $node->getArgs(); | ||
| if (! isset($args[0])) { | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
This is not possible, as one arg is required: https://www.php.net/manual/en/function.ord.php
Member
Author
There was a problem hiding this comment.
it is not error on older php version, eg: php 7.4, which only warning, but not error, the crash will on error because try to get ->value property on null.
Upgrade to php 8+ require runtime check on app level instead, not rector.
Member
There was a problem hiding this comment.
I've read the other comment 👌
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #7681 (review)