[fix] skip already dim fetch variable on OrdSingleByteRector#7681
Merged
Conversation
TomasVotruba
force-pushed
the
tv-ord-fix
branch
from
968316d to
c67cf06
Compare
TomasVotruba
changed the title
samsonasik
reviewed
Nov 29, 2025
| $args = $node->getArgs(); | ||
| $firstArg = $args[0]; | ||
|
|
||
| if (! isset($node->args[0])) { |
Member
There was a problem hiding this comment.
isset is needed in case someone for whatever doesn't have argument, or have remove argument via custom rule, this will cause error undefined index 0 and error:
Trying to get property 'value' of non-object
in php 7.4, it just warning, but not error
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
I see. Didn't know older Php version allow less args. Thanks 👌
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#9503, closes rectorphp/rector#9512
Related RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_passing_string_which_are_not_one_byte_long_to_ord