Skip to content

Add back removed fixture aliased multi properties on AnnotationToAttributeRector#7549

Merged
samsonasik merged 4 commits into
mainfrom
add-back-fixture
Oct 23, 2025
Merged

Add back removed fixture aliased multi properties on AnnotationToAttributeRector#7549
samsonasik merged 4 commits into
mainfrom
add-back-fixture

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Oct 23, 2025

@TomasVotruba here per #7548 (review)

The original PR that introduce it is at:

The fixture is needed. The case is same name in both annotation and attribute, but different namespace, and aliased is imported in multi properties.

@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba I've updated the fixture and source per your suggestion 👍 Ready to merge 👍

@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba let's merge 👍

@samsonasik samsonasik merged commit d549d62 into main Oct 23, 2025
60 of 61 checks passed
@samsonasik samsonasik deleted the add-back-fixture branch October 23, 2025 14:58
@TomasVotruba
Copy link
Copy Markdown
Member

Looks good 👍

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants