[ci] add short class fixture names check to avoid node class names#7548
Conversation
fe0a88a to
b4f559b
Compare
b4f559b to
111f057
Compare
| @@ -1,51 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
this fixture test is needed, I can create separate PR for update fixture with new class name to not conflict with Node name :)
There was a problem hiding this comment.
Same here. We already have this case covered. I remove these fixtures on purpose, to make tests more readable and maintainable.
There was a problem hiding this comment.
no, loop of multi properties is special :), because it already too early imported on class level, I will find a referenced PR :)
There was a problem hiding this comment.
Here the issue and PR that it fixed:
- AnnotationToAttributeRector only replace the first annotation when using use statement aliases rector#9114
- [Php80] Handle aliased with multi properties on AnnotationToAttributeRector #6838
the fixture is needed to avoid the patch removed in the future.
There was a problem hiding this comment.
@samsonasik It should at least re-use existing configuration. No need to add new configuration item, morever of non-existing class. That makes test less readable.
There was a problem hiding this comment.
sure, I will add to use existing config 👍
There was a problem hiding this comment.
| @@ -1,36 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
this fixture test is needed, I can create separate PR for update fixture with new class name to not conflict with Node name :)
There was a problem hiding this comment.
This is on purpose, not to create fixture per every possible item, but make them readable.
Don't add anything here.
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Uh oh!
There was an error while loading. Please reload this page.