Skip to content

AO3-7302 moved local variable to instance in meta partial #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CSTBook wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −8
Open

AO3-7302 moved local variable to instance in meta partial #5608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be7f985
AO3-7302 moved local variable to instance in meta partial
CSTBook Mar 2, 2026
ab4e9d4
AO3-7302 fixed linting errors
CSTBook Mar 2, 2026
6167787
AO3-7302 missed reference to works/meta
CSTBook Mar 3, 2026
452f683
AO3-7302 linting errors... again...
CSTBook Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/chapters/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<!--work description, metadata, notes and messages-->
<%= render "works/work_header_navigation" %>

<%= render "works/meta", work: @work %>
<%= render "works/meta" %>

<%= render "works/work_skin" %>

Expand Down
8 changes: 4 additions & 4 deletions app/views/works/_meta.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<% cache_unless(@preview_mode, "/v4/#{work.cache_key}-#{Work.work_blurb_version(work.id)}-meta-#{hide_warnings?(work) ? 'nowarn' : 'showwarn'}-#{hide_freeform?(work) ? 'nofreeform' : 'showfreeform'}", skip_digest: true) do %>
<% cache_unless(@preview_mode, "/v4/#{@work.cache_key}-#{Work.work_blurb_version(@work.id)}-meta-#{hide_warnings?(@work) ? 'nowarn' : 'showwarn'}-#{hide_freeform?(@work) ? 'nofreeform' : 'showfreeform'}", skip_digest: true) do %>
<h3 class="landmark heading"><%= ts("Work Header") %></h3>

<div class="wrapper">

<dl class="work meta group">
<% tag_group = work.tag_groups
<% tag_group = @work.tag_groups
Tag::VISIBLE.each do |type| %>
<% tags = tag_group[type] %>
<% unless tags.blank? %>
Expand All @@ -21,8 +21,8 @@

<dd class="<%= tag_type_css_class(type) %> tags">
<ul class="commas">
<% if (type == "ArchiveWarning" && hide_warnings?(work)) || (type == "Freeform" && hide_freeform?(work)) %>
<%= show_hidden_tag_link_list_item(work, type, { suppress_toggle_class: true }) %>
<% if (type == "ArchiveWarning" && hide_warnings?(@work)) || (type == "Freeform" && hide_freeform?(@work)) %>
<%= show_hidden_tag_link_list_item(@work, type, { suppress_toggle_class: true }) %>
<% else %>
<%= tag_link_list(tags, link_to_works=true) %>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/works/preview.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<!--main content-->
<div id="previewpane">
<div class="draft work">
<%= render "works/meta", work: @work %>
<%= render "works/meta" %>

<%= render "works/work_skin" %>

Expand Down
2 changes: 1 addition & 1 deletion app/views/works/preview_tags.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<!--main content-->
<div id="previewpane">
<div class="draft work">
<%= render 'works/meta', work: @work %>
<%= render "works/meta" %>
</div>
</div>
<!--/content-->
Expand Down
2 changes: 1 addition & 1 deletion app/views/works/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<!--work description, metadata, notes and messages-->
<%= render "works/work_header_navigation" %>

<%= render "works/meta", work: @work %>
<%= render "works/meta" %>

<%= render "works/work_skin" %>

Expand Down
Loading