AO3-7302 moved local variable to instance in meta partial#5608
AO3-7302 moved local variable to instance in meta partial#5608CSTBook wants to merge 4 commits intootwcode:masterfrom
Conversation
|
Just as another first timer who did this without checking someone else hadn't already (oops), I think there is also a reference to |
Thank you for pointing this out, dunno how I missed that reference! |
|
Hi, Neil C! Thank you so much for this pull request. The code looks good so I've marked this as reviewed. I've updated the Jira issue status to In Review so no one mistakenly creates another duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
|
@sempiternal-aurora Since we appear to be all out of open unassigned first timer only issues, you (or any other new contributor) are welcome to also work on unassigned open issues of easy or any other difficulty! That's always welcome, we just try to offer simple issues for first timers since getting the development environment set up can be enough of a challenge on its own for the first PR. I'm looking into creating more first timer only issues, but it can be a bit difficult for us to find suitably simple changes, so it may take some time |
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7302
Purpose
This PR changes the meta partial to use
@workas an instance variable instead of a local one, and also changes any references to the partial to ensure that they do not pass in@workas a parameter.Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
Neil C (he/him)
If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.
Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.