Skip to content

Adding finalizers logic while cleanup#76499

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
vishnuchalla:ols-finalizers
Mar 23, 2026
Merged

Adding finalizers logic while cleanup#76499
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
vishnuchalla:ols-finalizers

Conversation

@vishnuchalla
Copy link
Copy Markdown
Contributor

@vishnuchalla vishnuchalla commented Mar 19, 2026 •
edited
Loading

Description

Adding timeout for make undeploy and graceful exit. Also explicitly cleaning up finalizers.

Testing

Will be verifying using PR rehearsals.

@openshift-ci openshift-ci bot requested review from bparees and xrajesh March 19, 2026 01:53
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 19, 2026

@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 19, 2026

@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 19, 2026

@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

2 similar comments
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 22, 2026

@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 23, 2026

@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2026
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 23, 2026

@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 23, 2026

@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vishnuchalla
Adding finalizers logic while cleanup
4e65104 
Signed-off-by: Vishnu Challa <vchalla@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 23, 2026

[REHEARSALNOTIFIER]
@vishnuchalla: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-ols-load-generator-main-ols-load-test-1000workers N/A periodic Registry content changed
periodic-ci-openshift-ols-load-generator-main-ols-load-test-10workers N/A periodic Registry content changed
periodic-ci-openshift-ols-load-generator-main-ols-load-test-25workers N/A periodic Registry content changed
periodic-ci-openshift-ols-load-generator-main-ols-load-test-50workers N/A periodic Registry content changed
periodic-ci-openshift-ols-load-generator-main-ols-load-test-100workers N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@vishnuchalla
Copy link
Copy Markdown
Contributor Author

vishnuchalla commented Mar 23, 2026

/pj-rehearse periodic-ci-openshift-ols-load-generator-main-ols-load-test-10workers

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 23, 2026

@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vishnuchalla
Copy link
Copy Markdown
Contributor Author

vishnuchalla commented Mar 23, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 23, 2026

@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 23, 2026
@vishnuchalla
Copy link
Copy Markdown
Contributor Author

vishnuchalla commented Mar 23, 2026

/assign @xrajesh
/assign @raptorsun

@jtaleric
Copy link
Copy Markdown
Contributor

jtaleric commented Mar 23, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtaleric, vishnuchalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 340b52a into openshift:main Mar 23, 2026
9 of 10 checks passed
BaiyangZhou pushed a commit to BaiyangZhou/release that referenced this pull request Mar 24, 2026
@vishnuchalla @BaiyangZhou
Adding finalizers logic while cleanup (openshift#76499)
816439a 
Signed-off-by: Vishnu Challa <vchalla@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@xrajesh xrajesh Awaiting requested review from xrajesh

Assignees

@jtaleric jtaleric

@raptorsun raptorsun

@xrajesh xrajesh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vishnuchalla @openshift-ci-robot @jtaleric @raptorsun @xrajesh