Cleanup dependencies#217
Merged
Leonidas-from-XIV merged 2 commits intoocaml-dune:mainfrom Mar 11, 2026
Merged
Conversation
There is no need to build the test folder while building the main project nor should dependencies of the test project be installed for the main project. Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
cleanup-dependencies
branch
from
af868d3 to
677b337
Compare
Alizter
approved these changes
Mar 6, 2026
Contributor
Author
|
Now that #210 is merged and we don't rebuild to do config changes (where the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testfolder is used to verify that the Dune built as part of the workflow works. It it not a vendored project and the dependencies of it should not be dependencies of the main project.Removing these depencies will speed up builds as less code needs to be built.