Fix verification of artifacts in workflow#216
Fix verification of artifacts in workflow#216Leonidas-from-XIV merged 1 commit intoocaml-dune:mainfrom
Conversation
Signed-off-by: Marek Kubica <marek@tarides.com>
Sudha247
left a comment
There was a problem hiding this comment.
Looks fine to me!
It is a bit suspicious that dune doesn't treat the test directory as the project root. Makes me wonder if we need to have something to build in the test folder, but that's not for this PR.
|
I tried various things, like adding a valid Working on this I understood that |
For unknown to me reasons the
check-artifactsactions started failing because it couldn't read the dune file. It's unclear why this stopped working, no relevant change has been done.The source of the issue seems that when dune is trying to build the project in the
testfolder for some reason it traverses up into the containing folder (that of binary-distribution). This is also a dune project, however thedunefile was overwritten by the artifact unpacking, thusduneinstead of being a S-expression file is thedunebinary. Thus the Dune that is being tested tries to read that and fails.This whole setup is a bit of a mess, with multiple things being unpacked in the same place and potentially affecting each other. Thus this PR updates the code to:
dunefile is not overwritten by a binarydunebinary into~/.local/bininstead of the root directory--root .to prevent theduneunder test from traversing up fromtestThis change is done for both workflows as they suffer from the same issue. An example of a fixed workflow run can be seen in my fork (the workflow still fails eventually because it can't deploy due to lack of deployment secrets but the verification passes).