Have multiple configs instead of editing source code#210
Have multiple configs instead of editing source code#210Leonidas-from-XIV merged 12 commits intoocaml-dune:mainfrom
Conversation
c7c4698 to
4db6a38
Compare
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
The values are taken from the nightly workflow. Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
4db6a38 to
ef99b87
Compare
Signed-off-by: Marek Kubica <marek@tarides.com>
|
Looks ok to me. It might be worth re-asking: Do we really want to get rid of staging? Isn't the point to isolate from "prod"? |
|
I think we should have a way to test this, but the way this is currently setup is a mess:
What I think would be better is to have two environments with completely separate This is however a definitely out of the scope of this PR (and possibly more work than building a better design from scratch). So I can try to make this work with the staging branch but I am unsure whether it's worth the added work. @shonfeder what do you think? |
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
7bcebf5 to
c2822a3
Compare
I don't see a problem with keeping "the database" in the source code for a project like this. It give us an easy way to rollback, and keeps the infra minimal. Could we address your concerns with a
IMO, it is important that we can test changes before merging them into the trunk. But that doesn't necessarily mean we need a fixed staging branch: rather a way of deploying a selected branch to the staging environment. Does this make sense? |
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
c5a3cbb to
3740471
Compare
This PR changes the way Sandworm is reconfigured by moving from editing sourcecode as part of an GH workflow into using a config file.
Some notes about it:
testas an option to its execution. We need to rework how to test things in either case.