Conversation
mkj
force-pushed
the
pr/no-pubkey-real
branch
2 times, most recently
from
312fca1 to
5e054cd
Compare
This is common for any authentication method (password/pubkey/no auth required).
Applications shouldn't have any special handling for test versus actual pubkey auth requests. Remove the real() function since it can cause confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications shouldn't have any special handling for test versus actual pubkey auth requests. Remove the real() function since it can cause confusion.
ServEvent::Authenticatedcan be used instead