Fix ServEvent::Authenticated#46
Merged
Merged
Conversation
It needs to be put in the pending extra_resume_event member, to be emitted next time. Otherwise resume_event gets cleared on the next call to progress() Fixes: 7dba57d ("Add ServEvent::Authenticated")
All resume functions can discard the input payload on completion, so move that to Runner::resume() An extra set_extra_resume() function checks that it is not overwriting an existing event.
mkj
force-pushed
the
pr/fix-authenticated-event
branch
from
7773d41 to
46b5296
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServEvent::Authenticatedwasn't actually being emitted in #45This also adds more
debug_assert!checks and makes codepaths a bit more consistent.