Skip to content

Remove unused NodeCodeLoader class #26780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steffenloesch merged 3 commits into from
Mar 19, 2026
Merged

Remove unused NodeCodeLoader class #26780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a23bd3
Remove unused NodeCodeLoader class
steffenloesch Mar 19, 2026
45104ee
Merge remote-tracking branch 'upstream/main' into user/stloesch/remov…
steffenloesch Mar 19, 2026
38f0f5d
Merge branch 'main' into user/stloesch/remove-nodecodeloader
steffenloesch Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions server/routerlicious/packages/services/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,22 @@
},
"typeValidation": {
"broken": {
"Class_NodeAllowList": {
"forwardCompat": false,
"backCompat": false
},
"Class_NodeCodeLoader": {
"forwardCompat": false,
"backCompat": false
},
"Class_TenantManager": {
"forwardCompat": false
},
"ClassStatics_NodeAllowList": {
"backCompat": false
},
"ClassStatics_NodeCodeLoader": {
Comment thread
steffenloesch marked this conversation as resolved.
"backCompat": false
}
},
"entrypoint": "public"
Expand Down
1 change: 0 additions & 1 deletion server/routerlicious/packages/services/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export {
MongoDbFactory,
type ConnectionNotAvailableMode,
} from "./mongodb";
export { NodeAllowList, NodeCodeLoader } from "./nodeCodeLoader";
export { RedisCache } from "./redis";
export { ClientManager } from "./redisClientManager";
export {
Expand Down
135 changes: 0 additions & 135 deletions server/routerlicious/packages/services/src/nodeCodeLoader.ts
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions ...outerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ declare type current_as_old_for_Class_MongoDbFactory = requireAssignableTo<TypeO
* typeValidation.broken:
* "Class_NodeAllowList": {"forwardCompat": false}
*/
// @ts-expect-error compatibility expected to be broken
declare type old_as_current_for_Class_NodeAllowList = requireAssignableTo<TypeOnly<old.NodeAllowList>, TypeOnly<current.NodeAllowList>>
Comment thread
steffenloesch marked this conversation as resolved.

/*
Expand All @@ -213,6 +214,7 @@ declare type old_as_current_for_Class_NodeAllowList = requireAssignableTo<TypeOn
* typeValidation.broken:
* "Class_NodeAllowList": {"backCompat": false}
*/
// @ts-expect-error compatibility expected to be broken
declare type current_as_old_for_Class_NodeAllowList = requireAssignableTo<TypeOnly<current.NodeAllowList>, TypeOnly<old.NodeAllowList>>
Comment thread
steffenloesch marked this conversation as resolved.

/*
Expand Down Expand Up @@ -240,6 +242,7 @@ declare type current_as_old_for_Class_NodeClusterWebServerFactory = requireAssig
* typeValidation.broken:
* "Class_NodeCodeLoader": {"forwardCompat": false}
*/
// @ts-expect-error compatibility expected to be broken
declare type old_as_current_for_Class_NodeCodeLoader = requireAssignableTo<TypeOnly<old.NodeCodeLoader>, TypeOnly<current.NodeCodeLoader>>
Comment thread
steffenloesch marked this conversation as resolved.
Comment thread
steffenloesch marked this conversation as resolved.

/*
Expand All @@ -249,6 +252,7 @@ declare type old_as_current_for_Class_NodeCodeLoader = requireAssignableTo<TypeO
* typeValidation.broken:
* "Class_NodeCodeLoader": {"backCompat": false}
*/
// @ts-expect-error compatibility expected to be broken
declare type current_as_old_for_Class_NodeCodeLoader = requireAssignableTo<TypeOnly<current.NodeCodeLoader>, TypeOnly<old.NodeCodeLoader>>
Comment thread
steffenloesch marked this conversation as resolved.

/*
Expand Down Expand Up @@ -673,6 +677,7 @@ declare type current_as_old_for_ClassStatics_MongoDbFactory = requireAssignableT
* typeValidation.broken:
* "ClassStatics_NodeAllowList": {"backCompat": false}
*/
// @ts-expect-error compatibility expected to be broken
declare type current_as_old_for_ClassStatics_NodeAllowList = requireAssignableTo<TypeOnly<typeof current.NodeAllowList>, TypeOnly<typeof old.NodeAllowList>>
Comment thread
steffenloesch marked this conversation as resolved.

/*
Expand All @@ -691,6 +696,7 @@ declare type current_as_old_for_ClassStatics_NodeClusterWebServerFactory = requi
* typeValidation.broken:
* "ClassStatics_NodeCodeLoader": {"backCompat": false}
*/
// @ts-expect-error compatibility expected to be broken
declare type current_as_old_for_ClassStatics_NodeCodeLoader = requireAssignableTo<TypeOnly<typeof current.NodeCodeLoader>, TypeOnly<typeof old.NodeCodeLoader>>
Comment thread
steffenloesch marked this conversation as resolved.

/*
Expand Down
Loading