Skip to content

Remove unused NodeCodeLoader class#26780

Merged
steffenloesch merged 3 commits intomicrosoft:mainfrom
steffenloesch:user/stloesch/remove-nodecodeloader
Mar 19, 2026
Merged

Remove unused NodeCodeLoader class#26780
steffenloesch merged 3 commits intomicrosoft:mainfrom
steffenloesch:user/stloesch/remove-nodecodeloader

Conversation

@steffenloesch
Copy link
Contributor

Description

Removes the unused NodeCodeLoader class, and thereby resolves security concerns around some code in it.

Breaking Changes

Removes internal APIs NodeCodeLoader and NodeAllowList.

Copilot AI review requested due to automatic review settings March 19, 2026 15:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the internal NodeCodeLoader / NodeAllowList APIs (and their export surface), and updates the repo’s API/type-compat validation expectations to acknowledge the breaking change.

Changes:

  • Deleted nodeCodeLoader.ts (removing NodeCodeLoader and NodeAllowList implementations).
  • Removed re-exports from the services package entrypoint.
  • Updated type validation config + generated type-compat tests to expect compatibility breaks.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File Description
server/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts Adds @ts-expect-error annotations so generated type-compat checks compile despite expected breaking changes.
server/routerlicious/packages/services/src/nodeCodeLoader.ts Removes the NodeCodeLoader/NodeAllowList implementation entirely.
server/routerlicious/packages/services/src/index.ts Stops exporting the removed internal APIs from the package entrypoint.
server/routerlicious/packages/services/package.json Declares expected type-compat breaks for the removed classes/statics in typeValidation.broken.

You can also share your feedback on Copilot code review. Take the survey.

@steffenloesch steffenloesch enabled auto-merge (squash) March 19, 2026 16:24
@steffenloesch steffenloesch merged commit e85a05d into microsoft:main Mar 19, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants