Remove unused NodeCodeLoader class#26780
Merged
steffenloesch merged 3 commits intomicrosoft:mainfrom Mar 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the internal NodeCodeLoader / NodeAllowList APIs (and their export surface), and updates the repo’s API/type-compat validation expectations to acknowledge the breaking change.
Changes:
- Deleted
nodeCodeLoader.ts(removingNodeCodeLoaderandNodeAllowListimplementations). - Removed re-exports from the services package entrypoint.
- Updated type validation config + generated type-compat tests to expect compatibility breaks.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| server/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts | Adds @ts-expect-error annotations so generated type-compat checks compile despite expected breaking changes. |
| server/routerlicious/packages/services/src/nodeCodeLoader.ts | Removes the NodeCodeLoader/NodeAllowList implementation entirely. |
| server/routerlicious/packages/services/src/index.ts | Stops exporting the removed internal APIs from the package entrypoint. |
| server/routerlicious/packages/services/package.json | Declares expected type-compat breaks for the removed classes/statics in typeValidation.broken. |
You can also share your feedback on Copilot code review. Take the survey.
...r/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts
Show resolved
Hide resolved
...r/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts
Show resolved
Hide resolved
...r/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts
Show resolved
Hide resolved
...r/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts
Show resolved
Hide resolved
...r/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts
Show resolved
Hide resolved
...r/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts
Show resolved
Hide resolved
...r/routerlicious/packages/services/src/test/types/validateServerServicesPrevious.generated.ts
Show resolved
Hide resolved
anthony-murphy
approved these changes
Mar 19, 2026
jzaffiro
approved these changes
Mar 19, 2026
yunho-microsoft
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the unused
NodeCodeLoaderclass, and thereby resolves security concerns around some code in it.Breaking Changes
Removes internal APIs
NodeCodeLoaderandNodeAllowList.