Skip to content

Make NoArtifactError.Error() nil-safe #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdehamer merged 2 commits into from
Mar 20, 2026
Merged

Make NoArtifactError.Error() nil-safe #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3872598
Initial plan
Copilot Mar 20, 2026
03937e0
Make NoArtifactError.Error() nil-safe
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/deploymentrecord/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ type NoArtifactError struct {
}

func (n *NoArtifactError) Error() string {
if n == nil || n.err == nil {
return "no artifact found"
}
Comment on lines +173 to +175
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds a new behavior path (n == nil or n.err == nil) but there isn't a unit test asserting that (&NoArtifactError{}).Error() returns the expected message and does not panic. Adding a small regression test would prevent future reintroductions of the nil-deref.

Copilot uses AI. Check for mistakes.
return fmt.Sprintf("no artifact found: %s", n.err.Error())
Comment on lines 172 to 176
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error() is now nil-receiver safe, but Unwrap() still dereferences n unconditionally. If a nil *NoArtifactError is ever stored in an error interface, errors.Unwrap/Is can call Unwrap() and panic. Consider making Unwrap() return nil when the receiver is nil (and/or when n.err is nil) to keep the type fully nil-safe.

Copilot uses AI. Check for mistakes.
}

Expand Down
Loading