Make NoArtifactError.Error() nil-safe

[Copilot]

NoArtifactError.Error() would panic on a nil err field, making zero-value construction (&NoArtifactError{}) unsafe — a pattern used throughout controller tests.

Changes

• pkg/deploymentrecord/client.go: Guard against both a nil receiver and a nil wrapped error in Error(), returning "no artifact found" in either case

func (n *NoArtifactError) Error() string {
    if n == nil || n.err == nil {
        return "no artifact found"
    }
    return fmt.Sprintf("no artifact found: %s", n.err.Error())
}

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.