Draft
Conversation
This was referenced Jan 26, 2026
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-offline-caching
branch
4 times, most recently
from
4dd6c5e to
ff864c4
Compare
2 tasks
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-offline-caching
branch
from
ff864c4 to
a3db389
Compare
Collaborator
Author
|
@sentry review |
Collaborator
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-offline-caching
branch
from
a3db389 to
1cc6a7e
Compare
Collaborator
Author
|
@cursor review |
Wait for minidump upload to complete before proceeding in the cache tests to fix flaky CI failures across all platforms. Also reorder test_crashpad_cache_max_age to set file mtimes before the 5th crash to avoid timing issues with the cache. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixes test_crashpad_dumping_crash by checking for options->cache_keep before attempting to process completed reports. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Prevents creating malformed envelopes when __sentry-event file is missing or contains invalid msgpack data. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-offline-caching
branch
from
1cc6a7e to
7fc7a78
Compare
Collaborator
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts completed Crashpad reports to Sentry envelopes for offline caching.
<db>/completed/<db>/cache/Depends on:
ref(crashpad): pass predefined report ID #1488ref: exposemerge_breadcrumbsfor crashpad offline caching #1491feat: addsentry__value_from_msgpack#1492See also: