ref: expose merge_breadcrumbs for crashpad offline caching#1491
Merged
ref: expose merge_breadcrumbs for crashpad offline caching#1491
merge_breadcrumbs for crashpad offline caching#1491Conversation
JoshuaMoelans
approved these changes
Jan 26, 2026
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
Collaborator
Author
|
Safe to merge: exposes an existing function without behavioral changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, merging breadcrumbs was only needed for local vs. global scopes. Expose the functionality as internal
sentry__value_merge_breadcrumbshelper insentry_value.hto make it possible to use the same logic in offline caching for Crashpad (__sentry-breadcrumb1vs.__sentry-breadcrumb2). As a bonus, the PR comes with more fine-grained unit tests, as we can now access the helper directly in unit tests.Required for: