Skip to content

Fix RangeParameterConfig in from_config.py returns ChoiceParameter instead of RangeParameter #4599 #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wizardlyrocket8 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix RangeParameterConfig in from_config.py returns ChoiceParameter instead of RangeParameter #4599 #4910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ax/api/utils/instantiation/from_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,21 @@ def parameter_from_config(
"The range of the parameter must be evenly divisible by the "
"step size."
)

return ChoiceParameter(
return RangeParameter(
name=config.name,
parameter_type=_parameter_type_converter(config.parameter_type),
values=[*np.arange(lower, upper + step_size, step_size)],
is_ordered=True,
lower=lower,
upper=upper,
log_scale=config.scaling == "log",
)

return RangeParameter(
return ChoiceParameter(
name=config.name,
parameter_type=_parameter_type_converter(config.parameter_type),
lower=lower,
upper=upper,
log_scale=config.scaling == "log",
values=[*np.arange(lower, upper + step_size, step_size)],
is_ordered=True,
)
Comment on lines +53 to 65
Copy link
Copy Markdown
Contributor

@saitcakmak saitcakmak Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the return values in & out of the if statement changed places here. This doesn't seem like the correct behavior here.



elif isinstance(config, DerivedParameterConfig):
return DerivedParameter(
name=config.name,
Expand Down