Fix RangeParameterConfig in from_config.py returns ChoiceParameter instead of RangeParameter #4599

[wizardlyrocket8]

The original logic would return a ChoiceParameter after checking all the requirement for the RangeParameter. Now it checks if the instance is RangeParameterConfig and all of the conditions are met, the function return a RangeParameter.

if isinstance(config, RangeParameterConfig):
lower, upper = config.bounds

    # TODO[mpolson64] Add support for RangeParameterConfig.step_size native to
    # RangeParameter instead of converting to ChoiceParameter
    if (step_size := config.step_size) is not None:
        if not (config.scaling == "linear" or config.scaling is None):
            raise UserInputError(
                "Non-linear parameter scaling is not supported when using "
                "step_size."
            )

        remainder = (upper - lower) % step_size
        # Use tolerance-based comparison to handle floating point precision issues
        if not np.isclose(remainder, 0) and not np.isclose(remainder, step_size):
            raise UserInputError(
                "The range of the parameter must be evenly divisible by the "
                "step size."
            )
      return ChoiceParameter(
          name=config.name,
          parameter_type=_parameter_type_converter(config.parameter_type),
          values=[*np.arange(lower, upper + step_size, step_size)],
          is_ordered=True,
          sort_values=False,  # already sorted by np.arange.
      )
    return RangeParameter(
        name=config.name,
        parameter_type=_parameter_type_converter(config.parameter_type),
        lower=lower,
        upper=upper,
        log_scale=config.scaling == "log",
    )

[meta-cla]

Hi @wizardlyrocket8!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!