Skip to content

[Internal] Don't reload server on cli package changes #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
un-def merged 1 commit into from
Mar 27, 2026
Merged

[Internal] Don't reload server on cli package changes #3706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/dstack/_internal/cli/commands/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import argparse
import os
from pathlib import Path
from typing import Optional

from dstack._internal import settings
from dstack._internal.cli.commands import BaseCommand
Expand Down Expand Up @@ -81,11 +83,21 @@ def _command(self, args: argparse.Namespace):
uvicorn_log_level = os.getenv("DSTACK_SERVER_UVICORN_LOG_LEVEL", "ERROR").lower()
reload_disabled = os.getenv("DSTACK_SERVER_RELOAD_DISABLED") is not None

reload = settings.DSTACK_VERSION is None and not reload_disabled
reload_excludes: Optional[list[str]] = None
if reload:
# Don't reload on dstack._internal.cli package changes
for parent in Path(__file__).parents:
if parent.name == "cli":
reload_excludes = [str(parent)]
break

uvicorn.run( # type: ignore[unbound-variable]
"dstack._internal.server.main:app",
host=args.host,
port=args.port,
reload=settings.DSTACK_VERSION is None and not reload_disabled,
reload=reload,
reload_excludes=reload_excludes,
log_level=uvicorn_log_level,
workers=1,
)
Expand Down
Loading