Skip to content

github actions: Add 9.6 to kernel-build-and-tests workflow #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PlaidCat merged 1 commit into from
Feb 6, 2026
Merged

github actions: Add 9.6 to kernel-build-and-tests workflow #856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/kernel-build-and-test-x86_64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ jobs:
# Define whitelist of valid base branches
# TODO: Use a centralized place to get the base branches
VALID_BASES="ciqlts9_2 ciqlts9_4 ciqlts8_6"
VALID_BASES="ciqlts9_2 ciqlts9_4 ciqlts8_6 ciqlts9_6"
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of valid base branches is not ordered consistently. Consider ordering them either by version (major.minor) or maintaining a logical grouping. Current order mixes kernel 8 and kernel 9 branches: ciqlts9_2, ciqlts9_4, ciqlts8_6, ciqlts9_6. A more logical ordering would be either:

  1. By major version descending, then minor: ciqlts9_6 ciqlts9_4 ciqlts9_2 ciqlts8_6
  2. By major version ascending, then minor: ciqlts8_6 ciqlts9_2 ciqlts9_4 ciqlts9_6

This would improve readability and make it easier to identify missing or incorrectly placed entries in the future.

Suggested change
VALID_BASES="ciqlts9_2 ciqlts9_4 ciqlts8_6 ciqlts9_6"
VALID_BASES="ciqlts8_6 ciqlts9_2 ciqlts9_4 ciqlts9_6"

Copilot uses AI. Check for mistakes.
echo "Current branch: $BRANCH_NAME"
Expand Down