Skip to content

github actions: Add 9.6 to kernel-build-and-tests workflow#856

Merged
PlaidCat merged 1 commit intomainfrom
{jmaple}_main
Feb 6, 2026
Merged

github actions: Add 9.6 to kernel-build-and-tests workflow#856
PlaidCat merged 1 commit intomainfrom
{jmaple}_main

Conversation

@PlaidCat
Copy link
Collaborator

@PlaidCat PlaidCat commented Feb 6, 2026

@PlaidCat PlaidCat self-assigned this Feb 6, 2026
Copilot AI review requested due to automatic review settings February 6, 2026 16:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables GitHub Actions CI/CD workflows for the new ciqlts9_6 kernel branch by adding it to the whitelist of valid base branches in the kernel build and test workflow. This change allows the automated testing infrastructure to recognize and process pull requests targeting the ciqlts9_6 branch, which represents CIQ's Long Term Support kernel version 9.6. PR #855 demonstrates that the branch is operational with successful builds, boot verification, and kernel selftests.

Changes:

  • Added ciqlts9_6 to the VALID_BASES whitelist in the kernel build and test workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Define whitelist of valid base branches
# TODO: Use a centralized place to get the base branches
VALID_BASES="ciqlts9_2 ciqlts9_4 ciqlts8_6"
VALID_BASES="ciqlts9_2 ciqlts9_4 ciqlts8_6 ciqlts9_6"
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of valid base branches is not ordered consistently. Consider ordering them either by version (major.minor) or maintaining a logical grouping. Current order mixes kernel 8 and kernel 9 branches: ciqlts9_2, ciqlts9_4, ciqlts8_6, ciqlts9_6. A more logical ordering would be either:

  1. By major version descending, then minor: ciqlts9_6 ciqlts9_4 ciqlts9_2 ciqlts8_6
  2. By major version ascending, then minor: ciqlts8_6 ciqlts9_2 ciqlts9_4 ciqlts9_6

This would improve readability and make it easier to identify missing or incorrectly placed entries in the future.

Suggested change
VALID_BASES="ciqlts9_2 ciqlts9_4 ciqlts8_6 ciqlts9_6"
VALID_BASES="ciqlts8_6 ciqlts9_2 ciqlts9_4 ciqlts9_6"

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@bmastbergen bmastbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥌

@PlaidCat PlaidCat merged commit 747a90b into main Feb 6, 2026
6 checks passed
@PlaidCat PlaidCat deleted the {jmaple}_main branch February 6, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants