Initial work on improving spotless fixes

.github/scripts/generate-quality-report.py

@@ -776,12 +776,53 @@ def main() -> None:
             "EQ_ALWAYS_FALSE",
             "SBSC_USE_STRINGBUFFER_CONCATENATION",
             "SIC_INNER_SHOULD_BE_STATIC",
-            "EQ_DOESNT_OVERRIDE_EQUALS"
+            "EQ_DOESNT_OVERRIDE_EQUALS",
+            "CO_COMPARETO_INCORRECT_FLOATING",
+            "DL_SYNCHRONIZATION_ON_SHARED_CONSTANT",
+            "DLS_DEAD_LOCAL_STORE",
+            "DM_NUMBER_CTOR",
+            "DMI_INVOKING_TOSTRING_ON_ARRAY",
+            "EC_NULL_ARG",
+            "EC_UNRELATED_TYPES_USING_POINTER_EQUALITY",
+            "EQ_GETCLASS_AND_CLASS_CONSTANT",
+            "EQ_UNUSUAL",
+            "ES_COMPARING_STRINGS_WITH_EQ",
+            "FI_EMPTY",
+            "ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD",
+            "DM_GC",
+            "CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE",
+            "BC_UNCONFIRMED_CAST",
+            "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE",
+            "CN_IDIOM_NO_SUPER_CALL",
+            "DM_BOOLEAN_CTOR",
+            "DM_EXIT",
+            "EI_EXPOSE_REP",
+            "EI_EXPOSE_REP2",
+            "EI_EXPOSE_STATIC_REP2",
+            "EQ_COMPARETO_USE_OBJECT_EQUALS",
+            "MS_EXPOSE_REP",
+            "NM_CONFUSING",
+            "NO_NOTIFY_NOT_NOTIFYALL",
+            "NP_BOOLEAN_RETURN_NULL",
+            "REFLC_REFLECTION_MAY_INCREASE_ACCESSIBILITY_OF_CLASS",
+            "UI_INHERITANCE_UNSAFE_GETRESOURCE",
+            "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD",
+            "UW_UNCOND_WAIT",
+            "SIC_INNER_SHOULD_BE_STATIC_ANON"
         }
+
+        def _is_exempt(f: Finding) -> bool:
+            loc = f.path or f.location or ""
+            if f.rule == "SA_FIELD_SELF_ASSIGNMENT" and "InfBlocks.java" in loc:
+                return True
+            if f.rule == "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" and "TarEntry.java" in loc:
+                return True
+            return False
+
+
         violations = [
             f for f in spotbugs.findings
-            if f.rule in forbidden_rules
-            and not (f.rule == "SA_FIELD_SELF_ASSIGNMENT" and "InfBlocks.java" in f.location)
+            if f.rule in forbidden_rules and not _is_exempt(f)
         ]
         if violations:
             print("\n❌ Build failed due to forbidden SpotBugs violations:")

.github/workflows/designer.yml

@@ -39,6 +39,7 @@ jobs:
 
       - name: Build core dependencies
         run: |
+          xvfb-run -a ant -noinput -buildfile Ports/CLDC11/build.xml jar
           xvfb-run -a ant -noinput -buildfile Ports/JavaSE/build.xml jar
           xvfb-run -a ant -noinput -buildfile Ports/JavaSEWithSVGSupport/build.xml jar
           xvfb-run -a ant -noinput -buildfile CodenameOne/build.xml jar

CodenameOne/nbproject/project.properties

@@ -28,7 +28,7 @@ dist.jar=${dist.dir}/CodenameOne.jar
 dist.javadoc.dir=${dist.dir}/javadoc
 endorsed.classpath=
 excludes=
-file.reference.corevm.jar=../../cn1-binaries/corevm.jar
+file.reference.corevm.jar=../Ports/CLDC11/dist/CLDC11.jar
 includes=**
 jar.compress=false
 javac.classpath=\
@@ -76,4 +76,4 @@ source.encoding=windows-1252
 src.dir=src
 test.src.dir=test
 endorsed.classpath.cmd.line.arg=-bootclasspath ${file.reference.corevm.jar}
-codenameone.dir=../../CodenameOne
+codenameone.dir=../../CodenameOne

CodenameOne/src/com/codename1/capture/Capture.java

@@ -74,7 +74,7 @@ public static boolean hasCamera() {
      * @param response a callback Object to retrieve the file path
      * @throws RuntimeException if this feature failed or unsupported on the platform
      */
-    public static void capturePhoto(ActionListener response) {
+    public static void capturePhoto(ActionListener<ActionEvent> response) {
         Display.getInstance().capturePhoto(response);
     }
 
@@ -193,7 +193,7 @@ public static String capturePhoto(int width, int height) {
      * @param response a callback Object to retrieve the file path
      * @throws RuntimeException if this feature failed or unsupported on the platform
      */
-    public static void captureAudio(ActionListener response) {
+    public static void captureAudio(ActionListener<ActionEvent> response) {
         Display.getInstance().captureAudio(response);
     }
 
@@ -210,7 +210,7 @@ public static void captureAudio(ActionListener response) {
      * @throws RuntimeException if this feature failed or unsupported on the platform
      * @since 7.0
      */
-    public static void captureAudio(MediaRecorderBuilder recorderOptions, ActionListener response) {
+    public static void captureAudio(MediaRecorderBuilder recorderOptions, ActionListener<ActionEvent> response) {
         Display.getInstance().captureAudio(recorderOptions, response);
     }
 
@@ -224,7 +224,7 @@ public static void captureAudio(MediaRecorderBuilder recorderOptions, ActionList
      * @param response    a callback Object to retrieve the file path
      * @since 7.0
      */
-    public static void captureVideo(VideoCaptureConstraints constraints, ActionListener response) {
+    public static void captureVideo(VideoCaptureConstraints constraints, ActionListener<ActionEvent> response) {
         Display.getInstance().captureVideo(constraints, response);
     }
 
@@ -241,11 +241,11 @@ public static void captureVideo(VideoCaptureConstraints constraints, ActionListe
      * @throws RuntimeException if this feature failed or unsupported on the platform
      * @see #captureVideo(com.codename1.capture.VideoCaptureConstraints, com.codename1.ui.events.ActionListener)
      */
-    public static void captureVideo(ActionListener response) {
+    public static void captureVideo(ActionListener<ActionEvent> response) {
         Display.getInstance().captureVideo(response);
     }
 
-    static class CallBack implements ActionListener, Runnable {
+    static class CallBack implements ActionListener<ActionEvent>, Runnable {
         String url;
         private boolean completed;
         private int targetWidth = -1;
@@ -259,15 +259,18 @@ public void actionPerformed(ActionEvent evt) {
             }
             completed = true;
             synchronized (this) {
-                this.notify();
+                this.notifyAll();
             }
         }
 
         public void run() {
             while (!completed) {
                 synchronized (this) {
                     try {
-                        this.wait();
+                        // we need to recheck the condition within the synchronized block (double locking)
+                        if(!completed) {
+                            this.wait();
+                        }
                     } catch (InterruptedException ex) {
                     }
                 }

CodenameOne/src/com/codename1/capture/VideoCaptureConstraints.java

@@ -190,7 +190,7 @@ private String getMaxFileSizeString() {
 
     @Override
     public boolean equals(Object obj) {
-        if (obj.getClass() == VideoCaptureConstraints.class) {
+        if (obj instanceof VideoCaptureConstraints) {
             VideoCaptureConstraints c = (VideoCaptureConstraints) obj;
             return c.preferredHeight == preferredHeight &&
                     c.preferredWidth == preferredWidth &&

CodenameOne/src/com/codename1/charts/ChartComponent.java

@@ -208,7 +208,7 @@ public class ChartComponent extends Component {
      * @param chart The chart to be displayed in this component.
      */
     public ChartComponent(AbstractChart chart) {
-        setUIID("ChartComponent");
+        setUIIDFinal("ChartComponent");
         this.chart = chart;
         if (chart != null && chart instanceof XYChart) {
             XYChart xyChart = (XYChart) chart;

CodenameOne/src/com/codename1/charts/views/BubbleChart.java

@@ -27,17 +27,17 @@
 import java.util.List;
 
 
-/**
- * Displays series of {@link XYValueSeries} entries as proportional bubbles on
- * top of an {@link XYChart} plot.
- * <p>
- * Combine the chart with an {@link XYMultipleSeriesDataset} that contains one
- * or more {@link XYValueSeries} instances and supply an
- * {@link XYMultipleSeriesRenderer}. The resulting {@code BubbleChart} can be
- * wrapped in a {@link com.codename1.charts.ChartComponent} to embed it inside a
- * Codename One UI.
- */
-public class BubbleChart extends XYChart {
+/**
+ * Displays series of {@link XYValueSeries} entries as proportional bubbles on
+ * top of an {@link XYChart} plot.
+ * <p>
+ * Combine the chart with an {@link XYMultipleSeriesDataset} that contains one
+ * or more {@link XYValueSeries} instances and supply an
+ * {@link XYMultipleSeriesRenderer}. The resulting {@code BubbleChart} can be
+ * wrapped in a {@link com.codename1.charts.ChartComponent} to embed it inside a
+ * Codename One UI.
+ */
+public class BubbleChart extends XYChart {
     /** The constant to identify this chart type. */
     public static final String TYPE = "Bubble";
     /** The legend shape width. */
@@ -66,8 +66,8 @@ public BubbleChart(XYMultipleSeriesDataset dataset, XYMultipleSeriesRenderer ren
      * @param canvas the canvas to paint to
      * @param paint the paint to be used for drawing
      * @param points the array of points to be used for drawing the series
-     * @param seriesRenderer the series renderer
-     * @param yAxisValue the minimum value of the y axis
+     * @param renderer the series renderer
+     * @param yAxisValue the minimum value of the y-axis
      * @param seriesIndex the index of the series currently being drawn
      * @param startIndex the start index of the rendering points
      */

CodenameOne/src/com/codename1/charts/views/LineChart.java

@@ -349,7 +349,8 @@ public void drawLegendShape(Canvas canvas, SimpleSeriesRenderer renderer, float
      * @param renderer the series renderer
      */
     public boolean isRenderPoints(SimpleSeriesRenderer renderer) {
-        return ((XYSeriesRenderer) renderer).getPointStyle() != PointStyle.POINT;
+        return renderer instanceof XYSeriesRenderer &&
+                ((XYSeriesRenderer) renderer).getPointStyle() != PointStyle.POINT;
     }
 
     /**

CodenameOne/src/com/codename1/charts/views/ScatterChart.java

@@ -26,15 +26,15 @@
 import java.util.List;
 
 
-/**
- * Renders discrete X/Y points without connecting lines.
- * <p>
- * Configure the marker style through {@link XYSeriesRenderer#setPointStyle} and
- * related options on the {@link XYMultipleSeriesRenderer}. As with other
- * charts, wrap the instance in a {@link com.codename1.charts.ChartComponent} to
- * place it on a form.
- */
-public class ScatterChart extends XYChart {
+/**
+ * Renders discrete X/Y points without connecting lines.
+ * <p>
+ * Configure the marker style through {@link XYSeriesRenderer#setPointStyle} and
+ * related options on the {@link XYMultipleSeriesRenderer}. As with other
+ * charts, wrap the instance in a {@link com.codename1.charts.ChartComponent} to
+ * place it on a form.
+ */
+public class ScatterChart extends XYChart {
     /** The constant to identify this chart type. */
     public static final String TYPE = "Scatter";
     /** The default point shape size. */
@@ -203,7 +203,8 @@ public int getLegendShapeWidth(int seriesIndex) {
      */
     public void drawLegendShape(Canvas canvas, SimpleSeriesRenderer renderer, float x, float y,
                                 int seriesIndex, Paint paint) {
-        if (((XYSeriesRenderer) renderer).isFillPoints()) {
+        if (renderer instanceof  XYSeriesRenderer &&
+                ((XYSeriesRenderer) renderer).isFillPoints()) {
             paint.setStyle(Style.FILL);
         } else {
             paint.setStyle(Style.STROKE);