Skip to content

Initial work on improving spotless fixes #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shai-almog merged 59 commits into from
Jan 3, 2026
Merged

Initial work on improving spotless fixes #4375

shai-almog merged 59 commits into from
Jan 3, 2026
+3,280 −4,810

Conversation

@shai-almog
Copy link
Collaborator

@shai-almog shai-almog commented Dec 30, 2025

No description provided.

@shai-almog
Copy link
Collaborator Author

shai-almog commented Dec 30, 2025 •
edited
Loading

Compared 30 screenshots: 30 matched.

Native Android coverage

  • 📊 Line coverage: 25.08% (2686/10710 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.83% (12542/50502), branch 15.72% (734/4668), complexity 17.70% (750/4237), method 33.33% (606/1818), class 35.97% (109/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 25.08% (2686/10710 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.83% (12542/50502), branch 15.72% (734/4668), complexity 17.70% (750/4237), method 33.33% (606/1818), class 35.97% (109/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

@shai-almog
Copy link
Collaborator Author

shai-almog commented Dec 30, 2025 •
edited
Loading

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-arc
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

  • graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string-decorated
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

  • kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    kotlin
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 283 seconds
  • Compilation Time: 53 seconds

Detailed Performance Metrics

Metric Duration
Build Time Statistics
Setup & Unzip 26283 ms
Extract Extensions 15 ms
Google Services Setup 2 ms
Scan Classes 505 ms
Extract Libs 1070 ms
Inject Build Hints 34 ms
Generate Unit Tests 2 ms
Generate Stubs 1053 ms
Compile Stubs 2239 ms
Generate Icons 935 ms
Prepare ParparVM 143 ms
ParparVM Execution 161348 ms
Post-VM Setup 91 ms
CocoaPods 4301 ms
Finalize 19 ms
Total Time 198040 msMaven Overhead : 85000 ms
CocoaPods Install (Script) 1000 ms
Simulator Boot (Run) 44000 ms
App Install 14000 ms
App Launch 5000 ms
Test Execution 142000 ms

@shai-almog shai-almog force-pushed the Fixing-spotless-warnings branch 3 times, most recently from 9149580 to 10e345f Compare December 31, 2025 12:58
@shai-almog shai-almog force-pushed the Fixing-spotless-warnings branch from 10e345f to a7d864c Compare December 31, 2025 13:16
@shai-almog shai-almog force-pushed the Fixing-spotless-warnings branch 2 times, most recently from d500791 to 781b037 Compare December 31, 2025 17:57
google-labs-jules bot and others added 29 commits January 2, 2026 20:09
@google-labs-jules
Implement durationMode in TimeSpinner3D (#4379)
7198cdd 
* Implemented durationMode in TimeSpinner3D

Added setDurationMode(boolean) logic to toggle duration mode (0-24h range, no meridiem).
Updated addComponents to include "hours" and "minutes" labels when in duration mode.
Updated rebuildHours to adjust startHour/endHour for duration mode.
Verified with TimeSpinner3DTest.

* Implemented durationMode in TimeSpinner3D and added unit test.

- In `TimeSpinner3D.java`:
    - Implemented `setDurationMode(boolean)` to update state and rebuild UI.
    - Updated `addComponents` to add "hours" and "minutes" labels in duration mode.
    - Updated `rebuildHours` to set correct hour range (0-24) for duration mode.
- Added `TimeSpinner3DTest.java` in `maven/core-unittests` to verify duration mode behavior.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@shai-almog
Initial work on improving spotless fixes
486c2b9
@shai-almog
Fixed compilation issues and hardened build
d7266e3
@shai-almog
Improved CI build validation
7ae5f29
@shai-almog
Fixed unit test issues
a0423c6
@shai-almog
Fixed a bug and excluded some spotbugs tests
eb29eb0
@shai-almog
Removed additional settings
475a5ef
@shai-almog
Fixing exclusion logic
068aead
@shai-almog
Refined rules
fb3fe56
@shai-almog
Additional improvements
dfe0123
@shai-almog
Fixing exclusions to include inner classes
e601654
@shai-almog
Removed cloud storage package and further improvements
66b3358
@shai-almog
BindTarget was still used. Restored it and deprecated code
25bdfc1
@shai-almog
Trying again for TarEntry
93c13e4
@shai-almog
WTF
35b21ac
@shai-almog
Trying source name
ac345b3
@shai-almog
Fixed python script to ignore the tags failure
a3b6aa4
@shai-almog
Major fixes for calls from constructors
61b68f4
@shai-almog
Additional fixes and exclusions
aa627a0
@shai-almog
Further fixes
aa890ff
@shai-almog
Further refactorings to reduce warnings
2ab2b08
@shai-almog
Additional round of fixes
f5ec645
@shai-almog
Updated code
8903b5b
@shai-almog
Multiple fixes and removed call in constructor
f428c5e
@shai-almog
Further fixes
fa99f27
@shai-almog
Fixed most issues
a3869a2
@shai-almog
Fixed a few more bugs but didn't exclude yet
5eb12b1
@shai-almog
Merge branch 'Fixing-spotless-warnings' of https://github.com/codenam…
50be5e4 
…eone/CodenameOne into Fixing-spotless-warnings
@shai-almog
Deleted bad test code
89d106a
@shai-almog shai-almog merged commit c7ce914 into master Jan 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shai-almog @ThomasH99