Fix #22574: fix volumetric fog back-face intersection artifacts#23406
Open
joaoconceicao12 wants to merge 1 commit intobevyengine:release-0.18.0from
Open
Fix #22574: fix volumetric fog back-face intersection artifacts#23406joaoconceicao12 wants to merge 1 commit intobevyengine:release-0.18.0from
joaoconceicao12 wants to merge 1 commit intobevyengine:release-0.18.0from
Conversation
…acts Fixes angle-dependent volumetric fog artifacts in the atmosphere example (shadow flipping and hard edges while rotating the camera). Root cause was inconsistent back-face intersection setup: far-plane construction in CPU code and ray-plane intersection in WGSL shader code. This patch corrects both calculations and adds a regression test for far-plane positioning in volumetric fog (get_far_planes). Signed-off-by: João Conceição <joao.conceicao@tecnico.ulisboa.pt>
Contributor
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22574.
This PR fixes angle-dependent volumetric fog artifacts in the atmosphere example ([--features free_camera], where rotating the camera caused shadow flipping and hard edges.
Solution
The root cause was inconsistent back-face intersection setup between CPU and shader paths:
This PR:
Testing
video1.mov
Platform tested:
macOS (Metal backend).
No additional untested platform-specific behavior is currently known.