Skip to content

Fix duplicate html id errors #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbdiTolesa wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix duplicate html id errors #2951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fab01d3
Fix duplicate html id errors
AbdiTolesa Feb 11, 2026
945fa49
Fix potential bugs introduced in the last commit
AbdiTolesa Feb 23, 2026
15db8ba
Rebuild files
AbdiTolesa Feb 23, 2026
d3f315b
Merge branch 'master' into issue-5113
AbdiTolesa Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/views/frm-forms/add_field_links.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<div class="frm-tabs-navs">
<ul class="frm-flex-box">
<li class="frm-active">
<a href="#frm-insert-fields" id="frm_insert_fields_tab">
<a href="#frm-insert-fields" id="frm_add_fields_tab">
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for any remaining references to the old ID across all JS and PHP files
echo "=== Remaining references to frm_insert_fields_tab ==="
rg -n "frm_insert_fields_tab" --type=js --type=php -C 2

echo ""
echo "=== All references to frm_add_fields_tab (for completeness) ==="
rg -n "frm_add_fields_tab" --type=js --type=php -C 1

Repository: Strategy11/formidable-forms

Length of output: 50384

Update all remaining references to the old ID frm_insert_fields_tab to match the new ID frm_add_fields_tab.

The ID rename in the PHP file is incomplete. Stale references remain in:

  • js/src/admin/admin.js (lines 743, 10831)
  • tests/cypress/support/commands.js (line 70)

These will silently break tab-switching functionality and cause test failures.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@classes/views/frm-forms/add_field_links.php` at line 16, The PHP ID was
renamed to frm_add_fields_tab but remaining references to frm_insert_fields_tab
in the JS need updating; search for the string "frm_insert_fields_tab" in the
admin.js and tests/cypress support commands (the modules that handle tab
switching and test commands) and replace those occurrences with
"frm_add_fields_tab" so event listeners, click selectors and Cypress commands
target the new ID (verify selectors used in functions that toggle tabs or in the
Cypress custom command are updated accordingly).

<?php esc_html_e( 'Add Fields', 'formidable' ); ?>
</a>
</li>
Expand Down
Loading
Loading