Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated DOM identifier and related nav checks: the Add Fields anchor id was changed/removed, and multiple navigation click handlers were updated to use Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP |  |
Feb 23, 2026 7:13p.m. | Review ↗ |
| JavaScript | |
Feb 23, 2026 7:13p.m. | Review ↗ |
|
@AbdiTolesa I'm afraid that this will affect this line (and some similar lines): formidable-forms/js/src/admin/admin.js Line 742 in d957b46 Can you double-check it? |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@classes/views/frm-forms/add_field_links.php`:
- Line 16: The PHP ID was renamed to frm_add_fields_tab but remaining references
to frm_insert_fields_tab in the JS need updating; search for the string
"frm_insert_fields_tab" in the admin.js and tests/cypress support commands (the
modules that handle tab switching and test commands) and replace those
occurrences with "frm_add_fields_tab" so event listeners, click selectors and
Cypress commands target the new ID (verify selectors used in functions that
toggle tabs or in the Cypress custom command are updated accordingly).
In `@js/src/components/class-tabs-navigator.js`:
- Line 49: The comment above the conditional is stale: it says "Handle special
case for frm_insert_fields_tab" but the code now checks for frm_add_fields_tab;
update the comment to reference the correct ID (frm_add_fields_tab) or make it
generic (e.g., "Handle special case for add/insert fields tab") so it matches
the condition in the class-tabs-navigator component where the check for
frm_add_fields_tab occurs.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
classes/views/frm-forms/add_field_links.phpjs/addons-page.jsjs/formidable-settings-components.jsjs/formidable-web-components.jsjs/formidable_admin.jsjs/formidable_blocks.jsjs/formidable_dashboard.jsjs/frm_testing_mode.jsjs/src/components/class-tabs-navigator.js
| <ul class="frm-flex-box"> | ||
| <li class="frm-active"> | ||
| <a href="#frm-insert-fields" id="frm_insert_fields_tab"> | ||
| <a href="#frm-insert-fields" id="frm_add_fields_tab"> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check for any remaining references to the old ID across all JS and PHP files
echo "=== Remaining references to frm_insert_fields_tab ==="
rg -n "frm_insert_fields_tab" --type=js --type=php -C 2
echo ""
echo "=== All references to frm_add_fields_tab (for completeness) ==="
rg -n "frm_add_fields_tab" --type=js --type=php -C 1Repository: Strategy11/formidable-forms
Length of output: 50384
Update all remaining references to the old ID frm_insert_fields_tab to match the new ID frm_add_fields_tab.
The ID rename in the PHP file is incomplete. Stale references remain in:
js/src/admin/admin.js(lines 743, 10831)tests/cypress/support/commands.js(line 70)
These will silently break tab-switching functionality and cause test failures.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@classes/views/frm-forms/add_field_links.php` at line 16, The PHP ID was
renamed to frm_add_fields_tab but remaining references to frm_insert_fields_tab
in the JS need updating; search for the string "frm_insert_fields_tab" in the
admin.js and tests/cypress support commands (the modules that handle tab
switching and test commands) and replace those occurrences with
"frm_add_fields_tab" so event listeners, click selectors and Cypress commands
target the new ID (verify selectors used in functions that toggle tabs or in the
Cypress custom command are updated accordingly).
| @@ -48,7 +48,7 @@ export class frmTabsNavigator { | |||
|
|
|||
| // Handle special case for frm_insert_fields_tab | |||
There was a problem hiding this comment.
Stale comment still references the old ID.
The comment says // Handle special case for frm_insert_fields_tab but the condition on the next line now checks frm_add_fields_tab.
✏️ Proposed fix
- // Handle special case for frm_insert_fields_tab
+ // Handle special case for frm_add_fields_tab
const navLink = navItem.querySelector( 'a' );📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // Handle special case for frm_insert_fields_tab | |
| // Handle special case for frm_add_fields_tab | |
| const navLink = navItem.querySelector( 'a' ); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@js/src/components/class-tabs-navigator.js` at line 49, The comment above the
conditional is stale: it says "Handle special case for frm_insert_fields_tab"
but the code now checks for frm_add_fields_tab; update the comment to reference
the correct ID (frm_add_fields_tab) or make it generic (e.g., "Handle special
case for add/insert fields tab") so it matches the condition in the
class-tabs-navigator component where the check for frm_add_fields_tab occurs.
@truongwp I don't think that won't affect this line since the selector for this callback function doesn't match with the |
2 participants
Fix https://github.com/Strategy11/formidable-pro/issues/5113
I couldn't see the duplicate
frm-nav-tabserrors anymore but onlyfrm_insert_fields_tab, which is fixed in this issue.Summary by CodeRabbit
Bug Fixes
Chores