Skip to content

[SYNPY-1788] Comment out test due to synapse api error#1338

Open
linglp wants to merge 7 commits intodevelopfrom
synpy-1788
Open

[SYNPY-1788] Comment out test due to synapse api error#1338
linglp wants to merge 7 commits intodevelopfrom
synpy-1788

Conversation

@linglp
Copy link
Contributor

@linglp linglp commented Mar 13, 2026

Problem:

See https://sagebionetworks.jira.com/browse/PLFM-9532
The tests are failing because of a server side error.

Temporary Solution:

Comment out the test

@linglp linglp requested a review from a team as a code owner March 13, 2026 20:22
@thomasyu888
Copy link
Member

🔥 nice - did we look into whether this test if failing due to the recent updates within the usage of display vs class labels?

Also, I see that the test suite hasn't run to completion?

@linglp
Copy link
Contributor Author

linglp commented Mar 16, 2026

@thomasyu888 I saw there's a new error here: https://github.com/Sage-Bionetworks/synapsePythonClient/actions/runs/23148122241/job/67241945925 when running the tests with Python 3.14 (but the tests passed with Python 3.10) :

=========================== short test summary info ============================
FAILED tests/integration/synapseclient/models/async/test_virtualtable_async.py::TestVirtualTableWithDataOperations::test_virtual_table_data_queries - assert 6 == 3
 +  where 6 = len(      name age      city\n0    Alice  30  New York\n1      Bob  25    Boston\n2  Charlie  35   Chicago\n3    Alice  30  New York\n4      Bob  25    Boston\n5  Charlie  35   Chicago)
FAILED tests/integration/synapseclient/models/async/test_virtualtable_async.py::TestVirtualTableWithDataOperations::test_virtual_table_sql_updates - assert 6 == 3
 +  where 6 = len(      name age      city\n0    Alice  30  New York\n1      Bob  25    Boston\n2  Charlie  35   Chicago\n3    Alice  30  New York\n4      Bob  25    Boston\n5  Charlie  35   Chicago)
= 2 failed, 685 passed, 11 skipped, 10078 warnings, 21 rerun in 4083.07s (1:08:03) =

The error seems to suggest that the data in base_table_with_data got inserted two times, resulting in 6 rows instead of 3. I am trying out and see if explicitly requesting @pytest_asyncio.fixture would fix the fixture scope.

@thomasyu888 thomasyu888 requested a review from BryanFauble March 17, 2026 20:56
Copy link
Member

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants