Skip to content

Fix macOS name in the devices tab from 'Mac OS' to 'macOS' #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dozro merged 5 commits into from
Mar 17, 2026
+12 −1
Merged

Fix macOS name in the devices tab from 'Mac OS' to 'macOS' #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca3b160
Fix OS name check from 'Mac OS' to 'macOS'
DidiDidi129 Mar 17, 2026
3f51f7a
Revert Broken Changes
DidiDidi129 Mar 17, 2026
1b243b2
Make Mac OS, macOS in user-agent
DidiDidi129 Mar 17, 2026
4308179
Added changeset
DidiDidi129 Mar 17, 2026
5052aaf
Correct casing of 'Mac OS' to 'macOS' in devices tab
DidiDidi129 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-macos-casing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

Fix Mac OS to macOS in the the devices tab
8 changes: 7 additions & 1 deletion src/app/utils/user-agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ const isMobileOrTablet = (() => {
return false;
})();

const normalizeMacName = (os?: string) => {
if (!os) return os;
if (os === 'Mac OS') return 'macOS';
return os;
};

const isMac = result.os.name === 'Mac OS';

export const ua = () => result;
Expand All @@ -17,7 +23,7 @@ export const mobileOrTablet = () => isMobileOrTablet;

export const deviceDisplayName = (): string => {
const browser = result.browser.name;
const os = result.os.name;
const os = normalizeMacName(result.os.name);
if (!browser || !os) return 'Sable Web';
return `Sable on ${browser} for ${os}`;
};
Loading