Fix macOS name in the devices tab from 'Mac OS' to 'macOS'#328
Merged
dozro merged 5 commits intoSableClient:devfrom Mar 17, 2026
Merged
Fix macOS name in the devices tab from 'Mac OS' to 'macOS'#328dozro merged 5 commits intoSableClient:devfrom
dozro merged 5 commits intoSableClient:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates macOS detection in the user-agent utility, intended to align the OS name handling with “macOS”.
Changes:
- Changed the
isMacOS-name comparison from'Mac OS'to'macOS'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
you might want to convert your pr to a draft while working on it :) and i updated the title, to be a bit more clear, feel free to adjust it iyw |
Contributor
Author
|
Right everyone just ignore the earlier commits, I misunderstood the code. Trial and error fixed things though 👍 |
Contributor
Author
Thank you, I did 🫡 PS deleted a bunch of unnecessary comments for clarity to any reviewers lol |
7w1
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue where mac users would have their device name be Mac OS instead of macOS
Type of change
Checklist: