Skip to content

fix(call): respect saved camera/mic preferences when starting call from room header #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Just-Insane merged 2 commits into from
Mar 16, 2026
+8 −1
Merged

fix(call): respect saved camera/mic preferences when starting call from room header #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a446a1
fix(call): respect user camera/mic preferences when starting call fro…
Just-Insane Mar 16, 2026
cd1f7ef
chore: add changeset
Just-Insane Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-call-camera-default.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

Fix camera turning on by default when starting a call from the room header button
4 changes: 3 additions & 1 deletion src/app/features/room/RoomCallButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Room } from '$types/matrix-sdk';
import { useCallStart, useCallJoined } from '$hooks/useCallEmbed';
import { callEmbedAtom } from '$state/callEmbed';
import { useMatrixClient } from '$hooks/useMatrixClient';
import { useCallPreferences } from '$state/hooks/callPreferences';

interface RoomCallButtonProps {
room: Room;
Expand All @@ -14,13 +15,14 @@ export function RoomCallButton({ room }: RoomCallButtonProps) {
const callEmbed = useAtomValue(callEmbedAtom);
const joined = useCallJoined(callEmbed);
const mx = useMatrixClient();
const { microphone, video, sound } = useCallPreferences();

const isJoinedInThisRoom = joined && callEmbed?.roomId === room.roomId;

if (isJoinedInThisRoom) return null;

const handleStartCall = async () => {
startCall(room);
startCall(room, { microphone, video, sound });
try {
const now = Date.now();
// TODO not use as any one day someday i swear
Expand Down
Loading