fix(call): respect saved camera/mic preferences when starting call from room header#305
Merged
Just-Insane merged 2 commits intodevfrom Mar 16, 2026
Merged
fix(call): respect saved camera/mic preferences when starting call from room header#305Just-Insane merged 2 commits intodevfrom
Just-Insane merged 2 commits intodevfrom
Conversation
…m room header RoomCallButton was calling startCall(room) without passing preferences, which caused Element Call to use its own defaults (camera on) instead of the user's saved settings. Now reads preferences via useCallPreferences() and passes them to startCall(), matching the behavior of PrescreenControls. Fixes #285
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-305-sable.raspy-dream-bb1d.workers.dev | cd1f7ef | pr-305 |
Mon, 16 Mar 2026 19:30:21 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #285 — Camera was turning on by default when starting a call from the room header button, even when the user had previously disabled video in their call preferences.
Root cause
RoomCallButtoncalledstartCall(room)without passing any preferences. This causedcreateCallEmbedto fall back toCallEmbed's defaultCallControlState(which uses hardcoded defaults), ignoring the user's saved preferences stored incallPreferencesAtom.PrescreenControlsalready correctly passed{ microphone, video, sound }viauseCallPreferences()when starting a call from the in-room join button.RoomCallButtonwas missing this.Fix
Added
useCallPreferences()toRoomCallButtonand passed the preferences tostartCall(room, { microphone, video, sound }), matching the pattern used inPrescreenControls.