Draft
Conversation
All to bump minimatch deps
josephjclark
commented
Mar 19, 2026
| @@ -0,0 +1,9 @@ | |||
| import process from 'node:process'; | |||
| import { registerCompletionHandler } from 'ava'; | |||
Collaborator
Author
There was a problem hiding this comment.
ava says to do this in the docs, and I can see the export in the code. But at runtime I'm told that registerCompletionHandler does not exist!
josephjclark
commented
Mar 19, 2026
|
|
||
| mockServer.destroy = () => | ||
| new Promise<void>((resolve) => { | ||
| // Terminate WebSocket clients first so any pending socketDelay |
Collaborator
Author
There was a problem hiding this comment.
claude has been pushing all sorts of weirdness here which at the end of the day just isn't working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
A one or two-sentence description of what this PR does.
Fixes #
Implementation Details
A more detailed breakdown of the changes, including motivations (if not provided in the issue).
QA Notes
List any considerations/cases/advice for testing/QA here.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.