Merged
Conversation
a538b29 to
f27a5ea
Compare
Collaborator
Author
|
QA to run after merging to main
Kinda hard to test both - I may have to build a fake version |
Collaborator
Author
|
So on merging to main, the unpublished docker tag (already on GH but had failed to build earlier) got itself built. Great. I've just force-pushed the tag again - this should trigger the action but it should not publish the tag as it already exists EDIT: this is the run but it doesn't look right? https://github.com/OpenFn/kit/actions/runs/23312532255/job/67803325126 Aha - but the tagged branch used the older action. Updating the tag and running against the new action works beautifully https://github.com/OpenFn/kit/actions/runs/23312774565
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A problem with github actions is that if mulitple tags are pushed at once, the "on tag" trigger doesn't work.
This PR attempts to fix that:
This should (finally) enable better automation of docker builds
Fixes #457
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy