fix(tree): peel to the final tree entry#2489
Merged
Sebastian Thiel (Byron) merged 3 commits intomainfrom Mar 26, 2026
Merged
Conversation
Sebastian Thiel (Byron)
force-pushed
the
fix-entry-by-path
branch
from
04639a2 to
99662d0
Compare
…f it's a tree) Co-authored-by: GPT 5.4 <codex@openai.com>
Sebastian Thiel (Byron)
force-pushed
the
fix-entry-by-path
branch
from
99662d0 to
f5b0086
Compare
Co-authored-by: GPT 5.4 <codex@openai.com>
Sebastian Thiel (Byron)
force-pushed
the
fix-entry-by-path
branch
from
f5b0086 to
ccc8500
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccc8500b17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Sebastian Thiel (Byron)
force-pushed
the
fix-entry-by-path
branch
from
69921f9 to
6b45cfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tree::peel_to_entry{_by_path}to moveselfto the final tree entry when the leaf entry is a treeTesting
cargo test -p gix --test gix object::tree::Refs #2456
Context: #2456 (comment)