Refactor tree::peel_to_entry to make the intent more obvious#2492
Merged
Sebastian Thiel (Byron) merged 2 commits intoGitoxideLabs:mainfrom Mar 30, 2026
Merged
Refactor tree::peel_to_entry to make the intent more obvious#2492Sebastian Thiel (Byron) merged 2 commits intoGitoxideLabs:mainfrom
tree::peel_to_entry to make the intent more obvious#2492Sebastian Thiel (Byron) merged 2 commits intoGitoxideLabs:mainfrom
Conversation
Sebastian Thiel (Byron)
force-pushed
the
peel_to_entry
branch
from
cb7d088 to
3542230
Compare
Sebastian Thiel (Byron)
approved these changes
Mar 30, 2026
Member
Sebastian Thiel (Byron)
left a comment
Sebastian Thiel (Byron)
left a comment
There was a problem hiding this comment.
Thanks a lot!
I spent more time on this than I would have wanted to, and while I think the first commit is making it a little better, the second commit I disagree with. Generally, I prefer a version that won't change the state of the instance to anything that is not a tree if it can avoid it.
The slight awkwardness of the implementation probably also hints at the strange "tree really wants to reuse its own buffer to safe an allocation" premise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To me the intent is clearer this way, and I don't think we do any more or less work than before. Even though
selfis aTree, thefind()calls can invalidate this already so tracking the data ID instead of the last tree ID felt odd.The first commit is separate just to fix what I asked about in my comment in #2489. The MSRV check passes, so I think it's fine :D